Pantheon use mutter334 #73906

worldofpeace · 2019-11-22T09:27:46Z

Motivation for this change

Just opened for my testing and tracking.

Pantheon with latest mutter is almost stable, with only one real issue reported left

mutter 3.34: no notifications drawn elementary/gala#636

and maybe two crashes that I need to debug.

There still needs to be a change for g-s-d 3.32 elementary/gala#518 elementary/greeter#382, but I believe almost everything should be working.

Lastly tracking a weird graphical glitch elementary/os-patches#80, believe that's an issue in mutter which I've kept a patch for in 3.28

https://github.com/NixOS/nixpkgs/blob/139806d89d77a3c59785e4e59c00c7186e8e9ea6/pkgs/desktops/gnome-3/core/mutter/0001-Revert-ClutterActor-Preserve-valid-paint-volumes-til.patch

If we can't get the fixed timely I might move the patch into gnome3.mutter proper.

Things done

Notify maintainers

cc @

jonringer

nix-review passes on NixOS
diff LGTM
commits LGTM
can't test, don't run compatible DE

[30 built, 120 copied (350.3 MiB), 61.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73906
18 package were built:
pantheon.elementary-greeter pantheon.elementary-gsettings-schemas pantheon.elementary-session-settings pantheon.gala pantheon.switchboard-plug-pantheon-shell pantheon.switchboard-with-plugs pantheon.wingpanel pantheon.wingpanel-applications-menu pantheon.wingpanel-indicator-bluetooth pantheon.wingpanel-indicator-datetime pantheon.wingpanel-indicator-keyboard pantheon.wingpanel-indicator-network pantheon.wingpanel-indicator-nightlight pantheon.wingpanel-indicator-notifications pantheon.wingpanel-indicator-power pantheon.wingpanel-indicator-session pantheon.wingpanel-indicator-sound pantheon.wingpanel-with-indicators

jonringer · 2019-12-13T23:49:48Z

@worldofpeace status?

worldofpeace · 2019-12-13T23:53:35Z

These issues need to be fixed before I commit it to NixOS

then it's "sorta" stable and can be improved upon hopefully before our release.

worldofpeace · 2020-03-24T07:17:19Z

Yay, everything seems to be fixed upstream and we just need to port over elementary/gala#754 for elementary/greeter#382. I probably can keep it a 3.34 because in 3.36 there's likely missing components.

worldofpeace · 2020-03-28T23:55:51Z

Hmm, they've ported everything to 3.36 too. This is looking good.

worldofpeace · 2020-04-01T03:18:33Z

The greeter has had the new gala code ported over for media keys:

And I discovered one last major bug, and opened PRs with fixes:

pkgs/desktops/pantheon/desktop/gala/default.nix

jtojnar · 2020-04-06T04:17:19Z

pkgs/desktops/pantheon/default.nix

@@ -110,7 +110,9 @@ lib.makeScope pkgs.newScope (self: with self; {
  # We're using ubuntu and elementary's patchset due to reasons
  # explained here -> https://github.com/elementary/greeter/issues/92#issuecomment-376215614
  # Take note of "I am holding off on "fixing" this bug for as long as possible."
-  elementary-settings-daemon = callPackage ./services/elementary-settings-daemon { };
+  elementary-settings-daemon = callPackage ./services/elementary-settings-daemon {
+    inherit (gnome3) gnome-desktop;


Ugh, we should move this to top-level as well.

pkgs/desktops/pantheon/services/elementary-notifications/default.nix

pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix

Used for Pantheon

We have this bug elementary/gala#636 when using notifications in gala. It's likely to not really be fixed because all development is on the new notifications server.

So we can drop the meson.patch intree.

Needed to have a correct pantheon.session gnome-session file.

support 3.36

Mutter 3.36 in gala is almost ready. This reverts commit 7160b7c31c8a44ffdd0cd0f375624c2c9c834917.

worldofpeace · 2020-04-06T06:55:05Z

Found some bugs with do not disturb not working with the new notification server:
elementary/switchboard-plug-notifications#66
elementary/wingpanel-indicator-notifications#110 (merged)

They were using lookup from SettingsSchemaSource get_default, but without recursive being true.
Reading the docs that is going to always be a problem on NixOS:

The returned source may actually consist of multiple schema sources from different directories, depending on which directories were given in XDG_DATA_DIRS and GSETTINGS_SCHEMA_DIR. For this reason, all lookups performed against the default source should probably be done recursively.

worldofpeace · 2020-04-06T06:56:16Z

I opened a bunch more:
elementary/switchboard-plug-keyboard#278
elementary/greeter#425
elementary/onboarding#91
elementary/calendar#502
elementary/switchboard-plug-locale#119

worldofpeace · 2020-04-06T07:10:02Z

Woah, thank you @tintou for merging all of those PRs so quickly ✨

worldofpeace · 2020-04-06T07:11:47Z

I'm running this just fine. I think I can merge this.
(I wish I could make an exception for 20.03, but I don't know how stable it will be just yet)

ofborg bot added 6.topic: pantheon The Pantheon desktop environment 8.has: clean-up 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Nov 22, 2019

jonringer approved these changes Nov 24, 2019

View reviewed changes

worldofpeace mentioned this pull request Dec 6, 2019

Pantheon session crash after lock or suspend with multi-monitors #60082

Closed

worldofpeace force-pushed the pantheon-latest-mutter branch 2 times, most recently from 8085a72 to 7c6660d Compare December 9, 2019 07:22

worldofpeace force-pushed the pantheon-latest-mutter branch from 7c6660d to f84a20e Compare March 28, 2020 23:56

worldofpeace marked this pull request as ready for review March 28, 2020 23:56

worldofpeace added this to the 20.09 milestone Mar 28, 2020

worldofpeace added this to In progress in Pantheon via automation Mar 28, 2020

ofborg bot added 6.topic: nixos 8.has: documentation 8.has: module (update) 8.has: package (new) labels Mar 29, 2020

ofborg bot requested a review from davidak March 29, 2020 00:10

worldofpeace force-pushed the pantheon-latest-mutter branch 4 times, most recently from 99c8c93 to e9ce10c Compare April 1, 2020 03:08

worldofpeace force-pushed the pantheon-latest-mutter branch from e9ce10c to 7724612 Compare April 3, 2020 21:02

worldofpeace mentioned this pull request Apr 3, 2020

Pantheon update 2020-04-03 #84215

Merged

10 tasks

worldofpeace force-pushed the pantheon-latest-mutter branch from 7724612 to 7160b7c Compare April 6, 2020 02:24

worldofpeace force-pushed the pantheon-latest-mutter branch from 40650b2 to 029a855 Compare April 6, 2020 04:13

jtojnar reviewed Apr 6, 2020

View reviewed changes

worldofpeace force-pushed the pantheon-latest-mutter branch 2 times, most recently from d309535 to 4b94305 Compare April 6, 2020 04:46

ofborg bot added the ofborg-internal-error label Apr 6, 2020

worldofpeace force-pushed the pantheon-latest-mutter branch from 4b94305 to 74e2836 Compare April 6, 2020 05:23

worldofpeace removed the ofborg-internal-error label Apr 6, 2020

worldofpeace added 15 commits April 6, 2020 02:48

gnome3.mutter334: init

344a5a7

Used for Pantheon

pantheon.mutter: 328 -> 334

20feca4

pantheon.elementary-gsettings-schemas: add gala override

548d7ea

pantheon.elementary-settings-daemon: 3.30.2 -> 3.34.1

a1ced50

pantheon.elementary-notifications: init at 2020-04-04

b0f0003

nixos/pantheon: use new notifications

50fe769

We have this bug elementary/gala#636 when using notifications in gala. It's likely to not really be fixed because all development is on the new notifications server.

pantheon.elementary-session-settings: 5.0.3 -> 2019-11-12

741313d

So we can drop the meson.patch intree.

pantheon.elementary-session-settings: add g-s-d version mappings

53bea37

Needed to have a correct pantheon.session gnome-session file.

pantheon.gala: use-new-notifications default true

7281bc7

pantheon.elementary-default-settings: fix media key syntax

ec3ee84

pantheon.wingpanel: 2.3.0 -> 2020-04-04

c15059e

support 3.36

pantheon.elementary-settings-daemon: 3.34.1 -> 3.36.0

acc66c8

Revert "pantheon.elementary-settings-daemon: 3.34.1 -> 3.36.0"

bf0dd34

Mutter 3.36 in gala is almost ready. This reverts commit 7160b7c31c8a44ffdd0cd0f375624c2c9c834917.

pantheon.wingpanel-indicator-notifications: fix do not disturb

db29696

pantheon.switchboard-plug-notifications: fix do not disturb

30fef60

worldofpeace force-pushed the pantheon-latest-mutter branch from 74e2836 to 30fef60 Compare April 6, 2020 06:53

worldofpeace merged commit e41a9d2 into NixOS:master Apr 6, 2020

Pantheon automation moved this from In progress to Done Apr 6, 2020

worldofpeace deleted the pantheon-latest-mutter branch April 6, 2020 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pantheon use mutter334 #73906

Pantheon use mutter334 #73906

worldofpeace commented Nov 22, 2019

jonringer left a comment

jonringer commented Dec 13, 2019

worldofpeace commented Dec 13, 2019

worldofpeace commented Mar 24, 2020 •

edited

worldofpeace commented Mar 28, 2020

worldofpeace commented Apr 1, 2020 •

edited

jtojnar Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

Pantheon use mutter334 #73906

Pantheon use mutter334 #73906

Conversation

worldofpeace commented Nov 22, 2019

Motivation for this change

Things done

Notify maintainers

jonringer left a comment

Choose a reason for hiding this comment

jonringer commented Dec 13, 2019

worldofpeace commented Dec 13, 2019

worldofpeace commented Mar 24, 2020 • edited

worldofpeace commented Mar 28, 2020

worldofpeace commented Apr 1, 2020 • edited

jtojnar Apr 6, 2020

Choose a reason for hiding this comment

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Apr 6, 2020

worldofpeace commented Mar 24, 2020 •

edited

worldofpeace commented Apr 1, 2020 •

edited