git-machete: init at 2.12.1 #73907
git-machete: init at 2.12.1 #73907
Conversation
|
Works on macOS 10.15 |
|
this looks interesting. Do you plan to add the completion files ? with installShellCompletion for instance |
Good point. Will do. |
|
@teto I've added it unconditionally, as this is what the other git tools do as well. Tested successfully on NixOS. |
|
👍 LGTM |
There was a problem hiding this comment.
You can use installShellCompletion:
- install -D completion/git-machete.completion.bash $out/etc/bash_completion.d/git-machete
- install -D completion/git-machete.completion.zsh $out/share/zsh/site-functions/_git-machete
+ installShellCompletion
+ --name git-machete completion/git-machete.completion.bash
+ --name _git-machete completion/git-machete.completion.zsh
TIL. I've updated the PR to include this. |
There was a problem hiding this comment.
This doesn't build for me because you're missing pbr in nativeBuildInputs
Also, can we setup tests?
Those dependencies are at https://github.com/VirtusLab/git-machete/blob/master/test-requirements.txt, and belong in checkInputs. The test runner is tox.
|
@worldofpeace diff --git a/pkgs/applications/version-management/git-and-tools/git-machete/default.nix b/pkgs/applications/version-management/git-and-tools/git-machete/default.nix
index 9d81149d600..aafaa6659d3 100644
--- a/pkgs/applications/version-management/git-and-tools/git-machete/default.nix
+++ b/pkgs/applications/version-management/git-and-tools/git-machete/default.nix
@@ -1,4 +1,6 @@
-{ lib, buildPythonApplication, fetchPypi, installShellFiles }:
+{ lib, buildPythonApplication, fetchPypi
+, installShellFiles, pbr
+, flake8, mock, pycodestyle, pylint, tox }:
buildPythonApplication rec {
pname = "git-machete";
@@ -9,7 +11,12 @@ buildPythonApplication rec {
sha256 = "114kq396zq45jlibn1lp0nk4lmanj4w1bcn48gi7xzdm0y1nkzfq";
};
- nativeBuildInputs = [ installShellFiles ];
+ nativeBuildInputs = [ installShellFiles pbr ];
+
+ # TODO: Add missing check inputs (2019-11-22):
+ # - stestr
+ doCheck = false;
+ checkInputs = [ flake8 mock pycodestyle pylint tox ];
postInstall = ''
installShellCompletion --bash --name git-machete completion/git-machete.completion.bash |
|
Ah, merci bien @filalex77 ✨ That should be fine. |
|
@blitz You can |
|
@worldofpeace @filalex77 Done. |
Motivation for this change
Git machete is a tool for automating rebase-based workflows. See https://github.com/VirtusLab/git-machete for details.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @tfc @jtraue