liblapack: 3.8.0 -> 3.9.0 #73958
Merged
liblapack: 3.8.0 -> 3.9.0 #73958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Nov 24, 2019
markuskowa
force-pushed
the
upd-lapack
branch
from
867f7d0
to
7e44c6d
Compare
veprbl
approved these changes
Nov 24, 2019
There was a problem hiding this comment.
Went though Reference-LAPACK/lapack@v3.8.0...v3.9.0 and nothing stuck out as a potential breaking change. It seems like they did some improvements for discovery using cmake, but I don't think that there is much existing software that uses on that.
Ran nix-review on x86-64_darwin (without sandboxing):
1 package are marked as broken and were skipped:
openmodelica
9 package failed to build:
framac giac-with-xcas python27Packages.fipy python27Packages.scikits-odes python37Packages.optuna python37Packages.pytorchWithCuda python38Packages.pytorchWithCuda why3 xfitter
30 package were build:
compcert coqPackages.contribs.containers coqPackages.contribs.zorns-lemma coq_8_10 coq_8_5 coq_8_6 coq_8_7 coq_8_8 coq_8_9 csdp giac haskellPackages.lapack-carray haskellPackages.lapack-comfort-array haskellPackages.lapack-ffi liblapack magma mxnet petsc python27Packages.mxnet python27Packages.pysparse python37Packages.mxnet python37Packages.scikits-odes python38Packages.mxnet python38Packages.scikits-odes sage sageWithDoc satallax scs sundials sundials_3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New subroutines + bug fixes: http://netlib.org/lapack/lapack-3.9.0.html
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)build failures seem to be unrelated to liblapack update:
Result of
nix-review156 package failed to build:
45 package were build:
Notify maintainers
cc @ttuegel @veprbl @costrouc