Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx-sso: 0.16.1 -> 0.22.0 #73929

Merged
merged 1 commit into from Nov 25, 2019
Merged

nginx-sso: 0.16.1 -> 0.22.0 #73929

merged 1 commit into from Nov 25, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Nov 22, 2019

Motivation for this change

update nginx-sso

⚠️ Note that I only tested that the binary ran (and I accessed it with a browser to see the login page). I don't use nginx-sso yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

❯ nix path-info -S /nix/store/jhl6867ax44dp8ijvzsw5s3gv5qiccjl-nginx-sso-0.16.1-bin
/nix/store/jhl6867ax44dp8ijvzsw5s3gv5qiccjl-nginx-sso-0.16.1-bin 44707632

❯ nix path-info -S /nix/store/brcbzs0gq0k617q1q40c3ki1nxznccnr-nginx-sso-0.22.0-bin
/nix/store/brcbzs0gq0k617q1q40c3ki1nxznccnr-nginx-sso-0.22.0-bin 51235376

Notify maintainers

cc @delroth

@ofborg ofborg bot requested review from delroth and ehmry November 22, 2019 19:46
tomfitzhenry
tomfitzhenry approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@flokli flokli merged commit 2394eb5 into NixOS:master Nov 25, 2019
@bbigras bbigras deleted the nginx-sso branch November 25, 2019 16:35
@bbigras
Copy link
Contributor Author

bbigras commented Nov 25, 2019

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfitzhenry tomfitzhenry tomfitzhenry approved these changes

@delroth delroth Awaiting requested review from delroth

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @tomfitzhenry @flokli