Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/drone-server: init #73971

Closed
wants to merge 1 commit into from
Closed

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 23, 2019

Motivation for this change

#70519

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@davidak
Copy link
Member

davidak commented Jun 1, 2020

@filalex77 do you want to continue this? i would love to run drone natively on nixos. but in docker is also fine i guess

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2021

I also have drone-exec-runner packaged, so it works without docker: https://github.com/Mic92/dotfiles/blob/master/nixos/eve/modules/drone.nix

@hexop
Copy link

hexop commented Feb 15, 2021

I also have drone-exec-runner packaged, so it works without docker: https://github.com/Mic92/dotfiles/blob/master/nixos/eve/modules/drone.nix

I'm interested in packaging it for nixpkgs, as my first real contribution.
I can't see a license on your repo, can I use your module as a base for a PR?

@Mic92
Copy link
Member

Mic92 commented Feb 15, 2021

I also have drone-exec-runner packaged, so it works without docker: https://github.com/Mic92/dotfiles/blob/master/nixos/eve/modules/drone.nix

I'm interested in packaging it for nixpkgs, as my first real contribution.
I can't see a license on your repo, can I use your module as a base for a PR?

There you go: https://github.com/Mic92/dotfiles/blob/master/LICENSE.md

@hexop
Copy link

hexop commented Feb 15, 2021

I also have drone-exec-runner packaged, so it works without docker: https://github.com/Mic92/dotfiles/blob/master/nixos/eve/modules/drone.nix

I'm interested in packaging it for nixpkgs, as my first real contribution.
I can't see a license on your repo, can I use your module as a base for a PR?

There you go: https://github.com/Mic92/dotfiles/blob/master/LICENSE.md

Thanks, I'll start hacking on it ASAP

@pinpox

This comment has been minimized.

@pinpox

This comment has been minimized.

@Mic92

This comment has been minimized.

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2021

Related to this drone-runner-exec pr: #115003

@stale
Copy link

stale bot commented Sep 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 3, 2021
@davidak
Copy link
Member

davidak commented Mar 22, 2022

FYI: Drone is not fully open source anymore. There is a community fork of the last open version. https://woodpecker-ci.org/
We use it at https://codeberg.org/ and it works well. So i suggest to package that instead.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 22, 2022
@pinpox
Copy link
Member

pinpox commented Mar 23, 2022

FYI: Drone is not fully open source anymore. There is a community fork of the last open version. https://woodpecker-ci.org/ We use it at https://codeberg.org/ and it works well. So i suggest to package that instead.

I looked into it, but it seems to only support container-based runners. I'm using the exec runner and the ssh runner in droneCI extensively. Not sure what other features are missing in woodpecker. Drone still is fully open source, the licence just prohibits using certain parts for enterprise if I'm not mistaken.

@davidak
Copy link
Member

davidak commented Mar 23, 2022

Drone still is fully open source, the licence just prohibits using certain parts for enterprise

That violates freedom 0 of FSFs Free Software definition and is therefore not open source! It is source-available.

You are right that woodpecker does not support all features (yet) that newer drone versions have.

@Br1ght0ne Br1ght0ne closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants