Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh LinPhone ecosystem #74043

Merged
merged 7 commits into from
Nov 24, 2019
Merged

Refresh LinPhone ecosystem #74043

merged 7 commits into from
Nov 24, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 24, 2019

Motivation for this change

Main goal is to cleanup the last dependencies on mbedtls_1_3 which has been EoL for a while now
+ mediastreamer-openh264 update
+ fix many homepages pointing to non-existing pages under the linphone.org domain
+ add bcg729 library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c


Result of nix-review

12 package were build:
  • bcg729
  • bctoolbox
  • belcard
  • belle-sip
  • belr
  • bzrtp
  • linphone
  • mediastreamer
  • mediastreamer-openh264
  • msilbc
  • ortp
  • trx

Sorry, something went wrong.

+ move cmake and bcunit to nativeBuildInputs

+ use current mbedtls
+ license is now GPL2+
+ use pname/version
+ polarssl -> mbedtls
+ no need for configure flag to find mbedtls
+ remove openssl from inputs (it's not used)
+ fix git version CFLAGS
+ add bcg729 input
+ move bcunit to nativeBuildInputs
@ofborg ofborg bot requested a review from 7c6f434c November 24, 2019 19:04
@7c6f434c 7c6f434c merged commit 5b39722 into NixOS:master Nov 24, 2019
@c0bw3b c0bw3b deleted the pkg/belledonne branch November 24, 2019 20:37
@c0bw3b c0bw3b mentioned this pull request Dec 1, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants