Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string-machine: init at unstable-2020-01-20 #74041

Merged
merged 1 commit into from Jan 22, 2020
Merged

string-machine: init at unstable-2020-01-20 #74041

merged 1 commit into from Jan 22, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 24, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

please update the commit message:

string-machine: init at unstable-2019-11-12

@magnetophon
Copy link
Member Author

@jonringer Sorry, slipped trough the cracks!

jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[3 built, 1 copied (1.1 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74041
1 package built:
string-machine

@magnetophon magnetophon changed the title string-machine: init at unstable-12-11-2019 string-machine: init at unstable-2020-01-20 Jan 22, 2020
jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74041
1 package built:
string-machine

@jonringer jonringer merged commit 376d787 into NixOS:master Jan 22, 2020
@magnetophon magnetophon deleted the string-machine branch January 22, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @jonringer