sourcetrail: 2019.3.46 -> 2019.4.1 #73974
Conversation
Br1ght0ne
force-pushed
the
sourcetrail-2019.4.61
branch
from
6e8e4c3
to
3140cbf
Compare
|
@GrahamcOfBorg build sourcetrail |
There was a problem hiding this comment.
Looking at https://logs.nix.ci/?key=nixos/nixpkgs.73974&attempt_id=dd019a46-5ed0-4b3d-aa0c-dfdd958a4a3d
You are missing some dependencies:
imagemagickinnativeBuildInputs(forconvertat build time)- It complains about various libraries, apparently, you are supposed to set paths to Qt directly: https://github.com/CoatiSoftware/Sourcetrail#for-unix
linux_package.cmake just proves my point about no one understanding CMake. Build manager simply is not meant for installing dependencies. They should use find_package for Qt and let it find all its dependencies as well.
NIX_LDFLAGS = [ "-lrt" ]; might help for the undefined shm_open if this is correct. Or apply this patch CoatiSoftware/Sourcetrail#784
| runHook postInstall | ||
| ''; | ||
| nativeBuildInputs = [ boost168 cmake qt512.qtbase qt512.qtsvg ]; | ||
| buildInputs = [ dbus expat git openssl python3 zlib ]; |
There was a problem hiding this comment.
| buildInputs = [ dbus expat git openssl python3 zlib ]; | |
| buildInputs = [ boost168 qt512.qtbase qt512.qtsvg dbus expat git openssl python3 zlib ]; |
Is git needed at runtime? I doubt it will get picked up from here.
Are specific versions of boost and Qt needed? If so, there should be a comment with explanation. Though more generic versions are preferred whenever possible.
There was a problem hiding this comment.
There was a problem hiding this comment.
Then it is likely executed at build time and should go to nativeBuildInputs. Though note that fetchFromGitHub strips the .git directory so git will not be of any help.
| # XXX: Sourcetrail somehow copies the initial config files into the home | ||
| # directory without write permissions. We currently just copy them | ||
| # ourselves to work around this problem. | ||
| setup_config() { |
There was a problem hiding this comment.
Is this no longer a problem?
|
|
||
| substituteInPlace \ | ||
| $out/share/applications/sourcetrail.desktop \ | ||
| --replace /usr/bin/ $out/bin/ |
There was a problem hiding this comment.
Is this no longer a problem?
Br1ght0ne
force-pushed
the
sourcetrail-2019.4.61
branch
from
3140cbf
to
80ed831
Compare
Sourcetrail is now open source (GPL-3). - src: fetchurl -> fetchFromGitHub - remove installPhase - change meta - platforms: x86_64-linux -> all - license: unfree -> gpl3 - maintainers: add filalex77
Br1ght0ne
force-pushed
the
sourcetrail-2019.4.61
branch
from
80ed831
to
4773059
Compare
|
@GrahamcOfBorg build sourcetrail |
|
Did you make progress in the meantime? |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing because of #95530. |
Motivation for this change
Sourcetrail is now open source (GPL-3).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @midchildan
This change is