Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtpass: 1.3.2 cherry-pick to 19.09 #73973

Merged
merged 5 commits into from Nov 24, 2019
Merged

qtpass: 1.3.2 cherry-pick to 19.09 #73973

merged 5 commits into from Nov 24, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 23, 2019

Motivation for this change

Cherry-pick recent master changes for qtpass on 19.09.

Without these (the upgrade to 1.3.2), qtpass segfaults at startup if no pass database exists, making it unusable for new installs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @hrdinka

FYI @dtzWill

dtzWill and others added 5 commits November 23, 2019 16:55
@dtzWill @nh2
qtpass: 1.3.0 -> 1.3.1
a4f8fbe 
https://github.com/IJHack/QtPass/releases/tag/v1.3.1
(cherry picked from commit a009dcd)
@dtzWill @nh2
qtpass: point to lupdate
a18b47c 
(cherry picked from commit 7d733bb)
@dtzWill @nh2
qtpass: install man page
1564f43 
(cherry picked from commit a6ab41f)
@dtzWill @nh2
qtpass: add pwgen as optional runtime dep
0aac7ec 
(cherry picked from commit 6362fec)
@r-ryantm @nh2
qtpass: 1.3.1 -> 1.3.2
b23a4aa 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/qtpass/versions

(cherry picked from commit 99b5363)
@nh2 nh2 requested review from dtzWill and hrdinka November 23, 2019 16:30
@nh2
Copy link
Contributor Author

nh2 commented Nov 23, 2019

@GrahamcOfBorg build

@fpletz fpletz merged commit 246bca6 into NixOS:release-19.09 Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @fpletz @dtzWill @r-ryantm