ssmtp: use services.ssmtp not networking.defaultMailServer #74048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckauhaus this has conflicts in |
This PR is part of the networking.* namespace cleanup. ssmtp used to be configured via `networking.defaultMailServer` which is sort of misleading since it provides options only for ssmtp. Other dumb mail relays like nullmailer have always been living under services. The intent of this PR is to align ssmtp's options with those of similar services. Specifically, two renames have been done: * Rename `networking.defaultMailHost` to `services.ssmtp`. * Rename `directDelivery` to `enable` because this is what it basically does.
ckauhaus
force-pushed
the
ssmtp-named-ssmtp
branch
from
692987b
to
dd87e9e
Compare
|
check |
|
@GrahamcOfBorg test mailcatcher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR is part of the networking.* namespace cleanup.
ssmtp used to be configured via
networking.defaultMailServerwhich is sort of misleading since it provides options only for ssmtp. Other dumb mail relays like nullmailer have always been living under services.The intent of this PR is to align ssmtp's options with those of similar services. Specifically, two renames have been done:
networking.defaultMailHosttoservices.ssmtp.directDeliverytoenablebecause this is what it basically does.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @basvandijk