Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cage: fix build #73982

Merged
merged 1 commit into from Nov 23, 2019
Merged

cage: fix build #73982

merged 1 commit into from Nov 23, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Nov 23, 2019

Motivation for this change

cage build is also broken since #72999 due to a moved header file.

Using libGL seems to be the correct way to use the GL related headers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos

@B4dM4n
cage: fix build
f610983 
The build fails because some C headers got removed from mesa-19.2.2.
Using libGL seems to be the correct way to use GL related headers.
@adisbladis adisbladis self-assigned this Nov 23, 2019
@adisbladis
Copy link
Member

Let's just wait for ofborg to run it's checks. nox-review passes :)

@ofborg ofborg bot requested a review from primeos November 23, 2019 18:37
@adisbladis adisbladis merged commit c3a0db0 into NixOS:master Nov 23, 2019
@adisbladis
Copy link
Member

Thanks

@B4dM4n B4dM4n deleted the cage-fix-build branch November 23, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos Awaiting requested review from primeos

Assignees

@adisbladis adisbladis

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @adisbladis