-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php packages #73908
Update php packages #73908
Conversation
@GrahamcOfBorg build phpPackages.apcu phpPackages.ast phpPackages.composer phpPackages.memcached phpPackages.php-cs-fixer phpPackages.phpcbf phpPackages.phpcs phpPackages.protobuf phpPackages.psalm phpPackages.redis phpPackages.xdebug phpPackages.mongodb |
fd6a1a7
to
7378bba
Compare
@GrahamcOfBorg build php72 php73 |
@GrahamcOfBorg build php72Packages.apcu php72Packages.ast php72Packages.composer php72Packages.memcached php72Packages.php-cs-fixer php72Packages.phpcbf php72Packages.phpcs php72Packages.protobuf php72Packages.psalm php72Packages.redis php72Packages.xdebug php72Packages.mongodb |
@GrahamcOfBorg build php73Packages.apcu php73Packages.ast php73Packages.composer php73Packages.memcached php73Packages.php-cs-fixer php73Packages.phpcbf php73Packages.phpcs php73Packages.protobuf php73Packages.psalm php73Packages.redis php73Packages.xdebug php73Packages.mongodb |
@Izorkin Hey, I think we should rebase this on master. And I think we should have a PR doing one thing at the time, especially if there's many changes. So not refactoring things and upgrading packages at the same time. This PR's name is: "Update php packages" and it has some extra cleanup and refactoring. It's better to split it up. I think this PR is needed and I would like to get it in. Currently it has conflicts. But if we can have less cleanup and more pure updates so we get the updates in faster that would be great. |
@etu rebased and updated PR. |
Motivation for this change
Update php:
Update phpPackages:
cc @etu @aanderse
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @