Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update php packages #73908

Merged
merged 15 commits into from Dec 7, 2019
Merged

Update php packages #73908

merged 15 commits into from Dec 7, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 22, 2019 •
edited

Motivation for this change

Update php:

  • 7.2 to 7.2.25
  • 7.3 to 7.3.12

Update phpPackages:

  • ast to 1.0.5
  • composer to 1.9.1
  • memcached to 3.1.5
  • mongodb to 1.6.1
  • php-cs-fixer to 2.16.1
  • phpcbf to 3.5.3
  • phpcs to 3.5.3
  • phpstan to 0.12.0
  • protobuf to 3.11.1
  • psalm to 3.7.2
  • psysh to 0.9.12
  • redis to 5.1.1
  • xdebug to 2.8.1

cc @etu @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin Izorkin mentioned this pull request Nov 22, 2019
Closed
10 tasks
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 23, 2019

@GrahamcOfBorg build phpPackages.apcu phpPackages.ast phpPackages.composer phpPackages.memcached phpPackages.php-cs-fixer phpPackages.phpcbf phpPackages.phpcs phpPackages.protobuf phpPackages.psalm phpPackages.redis phpPackages.xdebug phpPackages.mongodb

@Izorkin Izorkin force-pushed the php-updates branch 6 times, most recently from fd6a1a7 to 7378bba Compare November 25, 2019 19:24
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php72 php73

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php72Packages.apcu php72Packages.ast php72Packages.composer php72Packages.memcached php72Packages.php-cs-fixer php72Packages.phpcbf php72Packages.phpcs php72Packages.protobuf php72Packages.psalm php72Packages.redis php72Packages.xdebug php72Packages.mongodb

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php73Packages.apcu php73Packages.ast php73Packages.composer php73Packages.memcached php73Packages.php-cs-fixer php73Packages.phpcbf php73Packages.phpcs php73Packages.protobuf php73Packages.psalm php73Packages.redis php73Packages.xdebug php73Packages.mongodb

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

cc @etu @aanderse - please check PR.

@etu
Copy link
Contributor

etu commented Dec 5, 2019

@Izorkin Hey, I think we should rebase this on master.

And I think we should have a PR doing one thing at the time, especially if there's many changes. So not refactoring things and upgrading packages at the same time.

This PR's name is: "Update php packages" and it has some extra cleanup and refactoring. It's better to split it up.

I think this PR is needed and I would like to get it in. Currently it has conflicts. But if we can have less cleanup and more pure updates so we get the updates in faster that would be great.

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 7, 2019

@etu rebased and updated PR.

@etu etu merged commit d55e77b into NixOS:master Dec 7, 2019
@Izorkin Izorkin deleted the php-updates branch December 7, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin globin is a code owner

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar is a code owner

@etu etu Awaiting requested review from etu

@javaguirre javaguirre Awaiting requested review from javaguirre

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @etu