Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vala updates #73904

Merged
merged 3 commits into from Nov 22, 2019
Merged

Vala updates #73904

merged 3 commits into from Nov 22, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Need latest vala 0.46 for elementary/gala#642 (comment) gala with mutter 3.34.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from jtojnar and peterhoeg November 22, 2019 09:20
@jtojnar
Copy link
Contributor

jtojnar commented Nov 22, 2019

Changelog looks fine: https://gitlab.gnome.org/GNOME/vala/blob/0.46.5/NEWS#L1-81

Hopefully the added constraints won’t break any programs. If they do, I would not block on this unless it is something blocking channel.

@worldofpeace
Copy link
Contributor Author

Changelog looks fine: https://gitlab.gnome.org/GNOME/vala/blob/0.46.5/NEWS#L1-81

Hopefully the added constraints won’t break any programs. If they do, I would not block on this unless it is something blocking channel.

The larger release was a week ago, so hopefully there's patches floating around if there's issues.

@worldofpeace worldofpeace merged commit 2f9cb40 into NixOS:staging Nov 22, 2019
@worldofpeace worldofpeace deleted the vala-updates branch November 22, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar