Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-frameworks.extra-cmake-modules: allow for unset qtPluginPrefix #73903

Merged
merged 1 commit into from Nov 23, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

pretty sure this is not meant to always be set, fixes fcitx build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
Copy link
Member

Thanks!

@Ericson2314 Ericson2314 merged commit 46acc24 into NixOS:master Nov 23, 2019
@jonringer jonringer deleted the fix-qtplugin-options branch November 23, 2019 02:23
@jonringer
Copy link
Contributor Author

I probably should have made this against staging... oh well, :)

@Ericson2314
Copy link
Member

Ericson2314 commented Nov 23, 2019

Less than 1000, so eh. It was fixing a regression too.

@ttuegel
Copy link
Member

ttuegel commented Dec 1, 2019

pretty sure this is not meant to always be set

@jonringer qtPluginPrefix must always be set for a Qt package. Is this a Qt package?

@jonringer
Copy link
Contributor Author

@ttuegel this was specifically in regards to the fcitix package, I just saw that it was failing on hydra and this was the appropriate fix after set -u is now set globally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants