Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #74023

Merged
merged 173 commits into from Nov 30, 2019
Merged

Staging next #74023

merged 173 commits into from Nov 30, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 24, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Jonathan Ringer and others added 30 commits November 5, 2019 09:40
disable python test which was previously failing anyway, but in previous
versions it was being ignored
dependencies:
perlPackages.TestFakeHTTPD: init at 0.08
Use fetchpatch and explain the issue
[staging] python3Packages.pycairo: 1.18.1 -> 1.18.2
gnome2.gnome_vfs: openssl-1.1 patch
libxml2: 2.9.9 -> 2.9.10, libxslt: 1.1.33 -> 1.1.34, addressing CVE-2019-18197
* format withn nixpkgs-fmt
* drop unnecessary flags
* do not propagate gupnp-igd (it is only in Requires.private)
tests are failing there

FAIL: test-is-public
====================
valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument).
FAIL test-is-public (exit status: 1)
FAIL: test-is-public-all
========================
valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument).
FAIL test-is-public-all (exit status: 1)
FAIL: test-is-cookie-domain-acceptable
======================================
valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument).
FAIL test-is-cookie-domain-acceptable (exit status: 1)
FAIL: test-is-public-builtin
============================
valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument).
FAIL test-is-public-builtin (exit status: 1)
FAIL: test-registrable-domain
=============================
valgrind: mmap-FIXED(0x7fff5f400000, 8388608) failed in UME (load_unixthread1) with error 22 (Invalid argument).
FAIL test-registrable-domain (exit status: 1)
Commit be38210 broke evaluation
on Darwin because it added these unconditional buildInputs
that don't evaluate on Darwin:

    libnice librdf lilv lv2 serd sord sratom

This commit fixes it, and also fixes recently-added new dependencies
for other packages accordingly.

It further fixes the build of many gstreamer packages on Darwin.
Fixes building gst_all_1.gst-plugins-good.

Patch backported from 0.52.0.
gstreamer 1.16.1
Hopefully commits will be more stable.
@jonringer
Copy link
Contributor

I removed pkgs/development/python-modules/azure-cli-core/default.nix from master (no longer needed for azure-cli package), you can delete changes to it here

@jonringer
Copy link
Contributor

jonringer commented Nov 28, 2019

to help move stabilization along, I reverted the conflicting commit. And resolved all-package.nix conflicts with preferring master changes

@FRidh FRidh merged commit f99271b into master Nov 30, 2019
@ajs124
Copy link
Member

ajs124 commented Dec 1, 2019

This seems to have broken python3.pkgs.deprecated. It was only a minor bump, but fails to build.

@worldofpeace
Copy link
Contributor

Hi @terlar @ajs124.

If a package is failing to build and you identified that a staging-next merged introduced it, could you open an issue? When it comes to python packages, there's frequent breakages on unstable.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2019

Fido has been already fixed in #74816

@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2019

Fixed python3Packages.deprecated in 9fe1b95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet