Remove GL framebuffer on macOS #504
Conversation
|
From the other PR:
@whitequark I don't see any of this above issues, the only thing I see that is strange is that the toolbar sometimes disappears for a frame or 2. |
Great! I assume they finally fixed whatever issue there was with GL layers. I'm going to recheck if this still works on Mavericks, I think. Feel free to remove all traces of |
Is it just the toolbar? Or does selection marquee and fps counter also blink? |
This comment has been minimized.
This comment has been minimized.
|
That was caused by a missing |
|
Cool! Shall I add it to this PR or will you do it along with the other changes you made? |
|
I'll do it. |
|
Great, thanks a lot! it's great to have a butter smooth SolveSpace again =) |
|
Applied as 9b61f98. Let me know if there are any issues. |
|
Working great on my end! Thanks a lot! |
|
Here is a macOS build from the latest master 54015b6 |
This is work done by @troughton (see: troughton/solvespace@42f187a).
See his comment in this issue: #354
I just wanted to turn it into a PR on this repository so more people can see it, and possibly try it out / continue working on it.
I can compile and run this, it make SolveSpace very fast again!
However, there is some flashing in the toolbar occurring now and then, and there are probably other issues that I haven't stumbled into yet.
Notice that this PR does not bring in the changes that @troughton made to src/render/gl3shader.cpp.
Those seemed to be another optimisation that I don't fully understand, and we might be able to do without.
Can someone tell me how to crash it / what needs to be done to get this working reliably?
This PR is supersedes #502