Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.arviz: init at 0.5.1 #73988

Merged
merged 2 commits into from Dec 12, 2019
Merged

python3Packages.arviz: init at 0.5.1 #73988

merged 2 commits into from Dec 12, 2019

Conversation

OmnipotentEntity
Copy link
Contributor

Motivation for this change

Introduce the python package arviz, which is a module for helping visualize Bayesian distributions. Particularly useful in Bayesian Neural Network analysis.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Nov 24, 2019

nix-review happy on macos 10.13

@OmnipotentEntity OmnipotentEntity mentioned this pull request Nov 25, 2019
Closed
jonringer
jonringer previously requested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should be:

python3Packages.arviz: init at 0.5.1

arviz alone would mean you are putting a top level attribute in all-packages.nix

@OmnipotentEntity OmnipotentEntity changed the title arviz: init at 0.5.1 python3Packages.arviz: init at 0.5.1 Nov 26, 2019
@OmnipotentEntity
Copy link
Contributor Author

commit message should be:

python3Packages.arviz: init at 0.5.1

arviz alone would mean you are putting a top level attribute in all-packages.nix

This should be fixed. I was able to fix the first remotely from my phone earlier today, but I didn't have access to Github to update the title.

@veprbl
Copy link
Member

veprbl commented Nov 26, 2019

nix-review happy on macos 10.13

@risicle I'm much surprised. I was able to build this only after downgrading tensorflow-estimator and tensorflow-tensorboard to 0.14.0 to make tensorflow-bin build (#73703). And then test_data_tfp.py would completely fail all four of its tests.

@OmnipotentEntity
Copy link
Contributor Author

@veprbl Can you give output? I have a MacOSX machine I can test on. But the issue might be (and commonly is based on the other tests) other packages in the ecosystem being just plain broken on NixOS. I can disable that test if we cannot come to a satisfactory method of making it work.

However, it should be noted that when @risicle left that review I had tests disabled. It was only at the prompting of @jonringer that I added them back in.

veprbl
veprbl approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works on darwin

@veprbl
Copy link
Member

veprbl commented Dec 11, 2019

@GrahamcOfBorg build python37Packages.arviz

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.arviz

jonringer
jonringer approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to see this squashed, otherwise LGTM

@veprbl veprbl merged commit aa3fcec into NixOS:master Dec 12, 2019
@OmnipotentEntity OmnipotentEntity deleted the arviz-0.5.1 branch December 12, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@veprbl veprbl veprbl approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OmnipotentEntity @risicle @veprbl @jonringer