Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 3dd7ed38db48
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 4ad6f1404a8c
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 22, 2019

  1. codimd: fix build 

    This package broke during the update of `nodejs-10_x` to `v10.17.0`[1]
since `node-gyp` got updated from `3.8.0` to `5.0.3` during the NPM
update to `6.10.2`[2] which is bundled in the `nodejs` release tarball.

This `node-gyp`-version is used by the build script for `codimd` to
build several dependencies such as `node-sqlite3`. Older `node-gyp`
versions expected source headers for the compilation in `~/.node-gyp`,
with `node-gyp@5.0.3`, headers are declared by using the `--nodedir`
option.

[1] 7785f49
[2] nodejs/node@e2291cf

(cherry picked from commit ba307dd)
    @Ma27
    Ma27 committed Nov 22, 2019
    Copy the full SHA
    4ad6f14 View commit details
    Browse the repository at this point in the history