Skip temporary copying to framebuffer. #502
Conversation
This is work done by @troughton.
|
|
Please put these in a separate commit. Having a single commit with deprecation updates and behavior changes makes the history hard to understand.
If you add a constraint, and double click on the text, can you edit it? Or does it disappear / become black eventually? What about scrollbars and tooltips? That's the reason it uses offscreen rendering right now. |
|
Allright, thanks for the info on what to test for, I'll do that in a bit. In the meantime I made a new PR that does not include the deprecation warnings over here: #504 So I am closing this one. |
This is work done by @troughton (see: troughton@42f187a).
See his comment in this issue: #354
I just wanted to turn it into a PR on this repository so more people can see it, and possibly try it out / continue working on it.
I also fixed some deprecation warnings I got in XCode on Catalina.
I can compile and run this, it make SolveSpace very fast again!
However, there is some flashing in the toolbar occurring now and then, and there are probably other issues that I haven't stumbled into yet.
Notice that this PR does not bring in the changes that @troughton made to
src/render/gl3shader.cppsince I am not sure what the purpose of these changes are.Can someone tell me how to crash it / what needs to be done to get this working reliably?