Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: e386d405d673
Choose a base ref
...
head repository: solvespace/solvespace
compare: 54015b6777d2
Choose a head ref
  • 2 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 23, 2019

  1. macOS: Don't use offscreen rendering. 

    Since Catalina or earlier this no longer causes artifacts when Cocoa
controls are overlaid on a GL layer. Conversely, offscreen rendering
is very slow, especially on HiDPI screens.

Co-Authored-By: Koen Schmeets <hello@koenschmeets.nl>
    @troughton @vespakoen @whitequark
    2 people authored and whitequark committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    9b61f98 View commit details
    Browse the repository at this point in the history

  2. Call glGetError() after glFinish(), not glFlush(). 

    As I understand it, both glGetError() and glFinish() are serializing
and blockig, so it makes more sense to call them at the same time.
glFlush() does not block.
    @whitequark
    whitequark committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    54015b6 View commit details
    Browse the repository at this point in the history