helm3: init at 3.0.0 (help wanted) #73916
Conversation
|
From the looks of the https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/go-packages/generic/default.nix you might want to try implementing a preInstall hook. I'm not terribly familiar with the infrastructure around building Go packages, so I might be a ways off! |
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/kubernetes/helm; |
There was a problem hiding this comment.
Please quote the url.
| sha256 = "0gx5gmj1470q3gj8v043dmm31skf83p1ckzdcfzx8wdjlglsljrj"; | ||
| }; | ||
|
|
||
| modSha256 = "06599w4rvipb669vc5rj62k2kjakz2vmpp270carf204qbm5grk8"; |
There was a problem hiding this comment.
Rebase on top of latest master and switch to vendorSha256.
|
|
||
| modSha256 = "06599w4rvipb669vc5rj62k2kjakz2vmpp270carf204qbm5grk8"; | ||
|
|
||
| goPackagePath = "helm.sh/helm/v3"; |
There was a problem hiding this comment.
I think this is not needed.
| goPackagePath = "helm.sh/helm/v3"; | ||
| subPackages = [ "cmd/helm"]; | ||
|
|
||
| #goDeps = ./deps.nix; |
Yea it's a bit hard to explain why this failed, and it's definitely not ideal that you've had this experience - it shouldn't be that hard and not intuitive + undocumented. However, I once saw this working for someone: https://github.com/NixOS/nixpkgs/pull/86927/files#diff-2663ae5d05323a4fc069b6f0f3e664fbR20 Question: If:
Then what's so wrong about having it colliding with the helm2 ? |
|
dont we have already kubernetes-helm in the repo ? should we close this ? |
yep |
Motivation for this change
Add helm3 version. This version is made as a separate package because helm of version 3 is completely different from version 2 (no tiller, different templates and logic, different go dependencies ). From the user view, there is a need for both versions at the same time, cause most of Kubernetes clusters work with helm2, and new ones with helm3 at the same time. The
default.nixis copied from the original helm package with modifications.Help wanted with rename output binary to helm3. I am new to nixpkgs (its my 2nd package, 1st isn't even merged yet). As said upper - both packages helm in nixpkgs (verions2) and helm3 needed. But with this
default.nixthis package produces executable output as 'helm' what conflicts with old helm package. I tried to rename output in different hooks likefixupPhase, and overridinginstallPhasebut with no success. I think its quite simple to do, but I can't google anything or find in mans.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)P.S. This is my first package build and first pr to nixpkgs, sorry if something wrong.