buildBazelPackage: allow specifying whether to remove rules_cc #74013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Newer versions of Bazel are moving away from built-in
rules_cc
and instead allow fetching it as an external dependency in aWORKSPACE
file. If removed in the fixed-output fetch phase, building will fail to download it. This can be seen e.g. in #73097.The new
rules_cc
live here, which say:This PR changes things to allow disabling removing
rules_cc
with a flag tobuildBazelPackage
, set totrue
by default to replicate the behavior today. Additionally, this only affects thedeps
derivations, which are fixed-output, and thus shouldn't affect any packages today.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @abbradar @Profpatsch