chromium: fix aarch64 build #74015
chromium: fix aarch64 build #74015
Conversation
|
This requires a libjack2 to build, which was fixed in #73779 and is currently in |
|
Can you fix the merge conflict, and rebase on top of staging, so this should build? |
|
fixed commit is here: bendlas@c829108 I held off merging it, because of the staging isse. should probably be merged, because build is already broken |
thefloweringash
force-pushed
the
chromium-aarch64
branch
from
128ac70
to
2aba80a
Compare
The skia patch no longer applies, and is no longer necessary. The current version of chromium doesn't build with gcc. This has been fixed upstream[1] and could be backported, but switching aarch64 to clang/llvm and making the build the same on all platforms is simpler. [1] https://chromium.googlesource.com/chromium/src/+/9662ec844017690d5fd56bf0f05ef6a540dd29c1
thefloweringash
force-pushed
the
chromium-aarch64
branch
from
2aba80a
to
376628a
Compare
|
ofborg timing out on 3600 seconds is to be expected, but the log up to that looks normal (we should do something about the warnings, that recently popped up, at some point) |
|
Oh, I just realized, the PR was against staging. That wouldn't have been necessary, I think, since chromium doesn't have any downstream. Or is this an aarch64-specific thing? Let's pick this into stable, on next staging merge. |
I went from the recommendation earlier in the thread. There's no real advantage in putting it onto master before staging merges since it depends on the libjack2 fixes in staging. |
|
@thefloweringash if you use chromium on aarch64, could you please add yourself to the chromium maintainers, so that you are pinged and can test version bumps like #75516? I cannot build or test on aarch64. |
I have an interest in making Chromium available on Aarch64. I'm adding myself here on a recommendation from @ivan [1]. [1] NixOS#74015 (comment)
The skia patch no longer applies, and is no longer necessary.
The current version of chromium doesn't build with gcc. This has been
fixed upstream[1] and could be backported, but switching aarch64 to
clang/llvm and making the build the same on all platforms is simpler.
[1] https://chromium.googlesource.com/chromium/src/+/9662ec844017690d5fd56bf0f05ef6a540dd29c1
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @