Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zola: fix build on macOS #73985

Merged
merged 1 commit into from Nov 24, 2019
Merged

zola: fix build on macOS #73985

merged 1 commit into from Nov 24, 2019

Conversation

killercup
Copy link
Member

Motivation for this change

Patches lockfile to update sass-sys to a version which includes
compass-rs/sass-rs#60

Fixes #72972

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dywedir

@killercup
zola: fix build on macOS
c90b210 
Patches lockfile to update sass-sys to a version which includes
compass-rs/sass-rs#60

Fixes NixOS#72972
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 23, 2019
@killercup killercup mentioned this pull request Nov 23, 2019
Closed
@ofborg ofborg bot requested a review from dywedir November 23, 2019 20:09
@veprbl
Copy link
Member

veprbl commented Nov 24, 2019

@GrahamcOfBorg build zola

@dywedir
Copy link
Member

dywedir commented Nov 24, 2019

Thank you!

@dywedir dywedir merged commit fc821db into NixOS:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zola 0.9.0 doesn't build on darwin
3 participants
@killercup @veprbl @dywedir