apple_sdk: broken link update #73984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
veprbl
reviewed
Nov 23, 2019
There was a problem hiding this comment.
Doesn't work for me:
# cat test.nix
with import <nixpkgs> { };
fetchurl {
url =
"http://swcdn.apple.com/content/downloads/33/36/041-90419-A_7JJ4H9ZHO2/xs88ob5wjz6riz7g6764twblnvksusg4ps/DevSDK_OSX1012.pkg";
sha256 = "1sggc70rypqwcjwr7ciavw8sczwll16cwqxdxrbw7r2qvy3b0nhx";
}
# nix-build test.nix --option substituters ""
these derivations will be built:
/nix/store/x76mzld15zspnyf312g52hmxhqz5hqkg-DevSDK_OSX1012.pkg.drv
building '/nix/store/x76mzld15zspnyf312g52hmxhqz5hqkg-DevSDK_OSX1012.pkg.drv'...
trying http://swcdn.apple.com/content/downloads/33/36/041-90419-A_7JJ4H9ZHO2/xs88ob5wjz6riz7g6764twblnvksusg4ps/DevSDK_OSX1012.pkg
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 20.4M 100 20.4M 0 0 11.3M 0 0:00:01 0:00:01 --:--:-- 11.3M
hash mismatch in fixed-output derivation '/nix/store/hxgqrabm865wl8nglyp6cw2g858nf0b2-DevSDK_OSX1012.pkg':
wanted: sha256:1sggc70rypqwcjwr7ciavw8sczwll16cwqxdxrbw7r2qvy3b0nhx
got: sha256:13xq34sb7383b37hwy076gnhf96prpk1b4087p87xnwswxbrisih
error: build of '/nix/store/x76mzld15zspnyf312g52hmxhqz5hqkg-DevSDK_OSX1012.pkg.drv' failed
|
Hmm that's odd it does for me. |
Once I extract, the contents appear to be identical: |
|
Should we run xar in postFetch? |
|
Running nix-prefetch-url on machines in the other parts of the world I still get |
|
Are you sure you reproduced it correctly? This is exactly what happens in the stdenv. |
This agrees with what I observe:
|
|
Oh I see. Perhaps I didn't test correctly yesterday, we can change the hash and target staging instead. |
|
Weird, it worked for me. I was able to build On the side note, if I run which I haven't ever seen before. |
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
|
@dredozubov Could you please rebase to staging? |
dredozubov
force-pushed
the
update-darwin-sdk-link
branch
from
6f0e8a5
to
1eb1891
Compare
dredozubov
requested review from
alyssais,
basvandijk,
cdepillabout,
Ericson2314,
FRidh,
jonringer,
matthewbauer,
peti,
thoughtpolice and
ttuegel
as code owners
veprbl
removed request for
cdepillabout,
ttuegel,
basvandijk,
Ericson2314,
FRidh,
alyssais and
jonringer
veprbl
added
the
9.needs: port to stable
|
@GrahamcOfBorg eval @dredozubov You did exactly what we asked, thank you. The issue with reviewers is a known one. One possible workaround is to first force push a common commit of both master and staging into your PR branch, then change the target branch of your PR on github (at this time your PR will have no changes), then you push current staging + your changes back to your PR branch. This time made me realise that we should really document this procedure. |
ofborg
bot
removed
6.topic: erlang
6.topic: GNOME
|
Found an issue on PR retargeting procedure #48491 |
veprbl
approved these changes
Nov 27, 2019
veprbl
pushed a commit
that referenced
this pull request
Nov 27, 2019
(cherry picked from commit 7233afc)
veprbl
added
8.has: port to stable
rvem
pushed a commit
to serokell/nixpkgs
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Apple DevSDK for OS X Sierra(10.12) became unavailable recently, so trying to build apple_sdk leads to this:
Things done
DevSDK link updated to the one still available. I'm leaving #73744 as a discussion for a possible DevSDK update.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @NixOS/darwin-maintainers
This change is