Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] mattermost-desktop: 4.2.3 -> 4.3.1 #74027

Merged
merged 2 commits into from Mar 30, 2020
Merged

[19.09] mattermost-desktop: 4.2.3 -> 4.3.1 #74027

merged 2 commits into from Mar 30, 2020

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Nov 24, 2019

Motivation for this change

This is a port of #72867 for 19.09, as requested by @knedlsepp.

Built and run in on a running NixOS unstable system, file uploading was working properly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp
Copy link
Member

Thx for taking the effort of making file upload work on 19.09.

@veprbl
Copy link
Member

veprbl commented Mar 30, 2020

@GrahamcOfBorg build mattermost-desktop

@veprbl veprbl merged commit 6d445f8 into NixOS:release-19.09 Mar 30, 2020
@jokogr jokogr deleted the u-19.09/mattermost-desktop-4.3.1 branch October 25, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jokogr @knedlsepp @veprbl @evils