Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xiaomi-tissot #47

Merged
merged 6 commits into from Nov 23, 2019
Merged

Add support for xiaomi-tissot #47

merged 6 commits into from Nov 23, 2019

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Oct 28, 2019 •
edited

Not sure what the most appropriate place to merge this is; I based it on a merge of xiaomi-lavender and better-demo because that's what I essentially based it on while working on it. We may want to rebase some of that out. I also included fbterm and stage-2 adb support for convenience, but those should probably be removed as well.

This adds support for the Xiaomi Mi A1 (tissot), based on the kernel used in LineageOS 15.1. LOS 16.0 has a newer 4.9-based kernel, but I haven't got that to boot yet.

What works:

  • Boot
  • X on fbdev
  • Touchscreen
  • USB OTG with keyboard/mouse
  • adb
  • USB RNDIS gadget (but the kernel produces lots of slow-path warnings when this is used)
  • USB-C hub with charging and HID devices

@samueldr
Copy link
Member

As far as rebasing, I can manage once I resume work after the trip.

@samueldr
Copy link
Member

samueldr commented Oct 30, 2019 •
edited

I don't see any xiaomi-tissot related files in there... Something went wrong during a push? Uhhhh... something weird must have happened with github??

samueldr
samueldr requested changes Oct 30, 2019
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, the misc. commits unrelated will have to be rebased off this PR. If you don't have the time to get this done, or not sure, I can do it and ask you to validate it still works :).

devices/devices-to-json.rb Outdated Show resolved Hide resolved
devices/xiaomi-tissot/default.nix Outdated Show resolved Hide resolved
@samueldr samueldr added the 4. type: port New device port label Nov 7, 2019
@lheckemann lheckemann force-pushed the tissot-cleanup branch 3 times, most recently from bd0b79e to d09e514 Compare November 16, 2019 20:17
@lheckemann
Copy link
Member Author

How does this look? I've still got one commit from another branch of yours (cherry-picked with -x here currently), since we need to be able to pass makeFlags.

samueldr
samueldr requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the in-line comment, the kernel config needed a bit of normalization, through bin/kernel-normalize-config. This is the result.

devices/xiaomi-tissot/kernel/default.nix Outdated Show resolved Hide resolved
@lheckemann
devices/xiaomi-tissot: init
25ab9e3 
Kernel patch is copied from xiaomi-lavender.
@lheckemann
tissot: enable namespaces for sandbox
ee722a7
@lheckemann
tissot: fix colours
6537a5e 
Patch copied from motorola-addison
@lheckemann
Copy link
Member Author

Config renamed and normalised in all the commits (using filter-branch). Will need to go home and test this :)

@samueldr
Copy link
Member

You didn't need to normalize in all the past commits, as long as the result is right. Though it's fine to do so.

Hopefully everything's working and I can push that green button :).

@lheckemann
Copy link
Member Author

Yep, works! 🎉

@samueldr samueldr merged commit 6198805 into NixOS:master Nov 23, 2019
@lheckemann lheckemann deleted the tissot-cleanup branch November 24, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr requested changes

Assignees
No one assigned
Labels
4. type: port New device port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @samueldr