Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wlroots: fix build #73977

Merged
merged 1 commit into from Nov 23, 2019
Merged

wlroots: fix build #73977

merged 1 commit into from Nov 23, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Nov 23, 2019

Motivation for this change

wlroots build is broken since #72999 due to a moved header file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (cage is also broken due to a missing header)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos @adisbladis

@B4dM4n
wlroots: fix build
320d6e3 
add missing header that changed in mesa-19.2.2
@ofborg ofborg bot requested a review from primeos November 23, 2019 17:26
@primeos primeos self-assigned this Nov 23, 2019
primeos
primeos approved these changes Nov 23, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix! :)

@primeos primeos merged commit d1ee508 into NixOS:master Nov 23, 2019
@B4dM4n B4dM4n deleted the wlroots-fix-build branch November 23, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @primeos