Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spaCy 2.2.3 and required dependency updates #73912

Merged
merged 3 commits into from Nov 24, 2019
Merged

spaCy 2.2.3 and required dependency updates #73912

merged 3 commits into from Nov 24, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/explosion/spaCy/releases/tag/v2.2.3

This update also requires a new derivation, catalogue, and a version bump to the wasabi derivation. These changes are bundled in this PR.

Tested using the small English model.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.spacy

jonringer
jonringer approved these changes Nov 24, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (failures are unrelated to PR)
diff LGTM
commits LGTM

[14 built (1 failed), 58 copied (124.0 MiB), 24.4 MiB DL]
error: build of '/nix/store/7m40pcb7rlln9sx8x4nxfihcgdccqbn0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73912
2 package failed to build:
python38Packages.spacy python38Packages.textacy

11 package were built:
python27Packages.catalogue python27Packages.thinc python27Packages.wasabi python37Packages.catalogue python37Packages.spacy python37Packages.textacy python37Packages.thinc python37Packages.wasabi python38Packages.catalogue python38Packages.thinc python38Packages.wasabi

@jonringer jonringer merged commit ba718f5 into NixOS:master Nov 24, 2019
@danieldk danieldk deleted the spacy-2.2.3 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer