Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn2nix-moretea: v1.0.0-36-g3f2dbb0 -> v1.0.0-39-g9e7279e #73911

Merged
merged 1 commit into from Nov 22, 2019
Merged

yarn2nix-moretea: v1.0.0-36-g3f2dbb0 -> v1.0.0-39-g9e7279e #73911

merged 1 commit into from Nov 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2019

Motivation for this change

The command-line tool was not changed, but the nix expression was. It includes the following new changes:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

yarn2nix-moretea: v1.0.0-36-g3f2dbb0 -> v1.0.0-39-g9e7279e
9681920 
Includes the following upstream commits:

- Fix for package.json without a version (nix-community/yarn2nix#113)
- Don't access package.json via filtered src (nix-community/yarn2nix#115)
- remove redundant rec (nix-community/yarn2nix#119)
@zimbatm zimbatm merged commit ed90e59 into NixOS:master Nov 22, 2019
@ghost ghost mentioned this pull request Nov 23, 2019
Merged
10 tasks
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
@dtzWill
yarn2nix-moretea: v1.0.0-36-g3f2dbb0 -> v1.0.0-39-g9e7279e (NixOS#73911)
34abaf1 
Includes the following upstream commits:

- Fix for package.json without a version (nix-community/yarn2nix#113)
- Don't access package.json via filtered src (nix-community/yarn2nix#115)
- remove redundant rec (nix-community/yarn2nix#119)

(cherry picked from commit ed90e59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zimbatm