Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.azure-cli-{core,telemetry}: remove #74012

Merged
merged 2 commits into from Nov 25, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2019

Motivation for this change

thought this would be useful to help with adding azure-cli back to nixpkgs, turns out that these packages are in the same repo and really serve no other purpose other than helping in building azure-cli.

Removing azure-cli-core as it is broken due to non-latest versions of azure-mgmt-resource is needed.
Azure-cli-telemetry is being removed as it's only useful to azure-cli, and is built as part of the azure-cli package now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ nix-env -f /home/jon/.cache/nix-review/pr-74012/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing changed
https://github.com/NixOS/nixpkgs/pull/74012
$ nix-shell /home/jon/.cache/nix-review/pr-74012/shell.nix

@jonringer
Copy link
Contributor Author

removing, nix-review passes.

@jonringer jonringer merged commit 3dd81af into NixOS:master Nov 25, 2019
@jonringer jonringer deleted the remove-azure-cli-deps branch November 25, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant