Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.portalocker: fix build #74011

Merged
merged 1 commit into from
Nov 24, 2019
Merged

python3Packages.portalocker: fix build #74011

merged 1 commit into from
Nov 24, 2019
+0 −7

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2019 •
edited
Loading

Motivation for this change

forgot I upstreamed the patch, and bumped the version which included the patch, this now fails due to the patch failing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

azure-cli-core fails expectedly, as it requires an old version of azure-mgmt-resource

[9 built (3 failed), 139 copied (70.7 MiB), 13.4 MiB DL]
error: build of '/nix/store/73xrbkbrrhay90ghz5lp05iz3y4p3pqg-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/74011
3 package failed to build:
python27Packages.azure-cli-core python37Packages.azure-cli-core python38Packages.azure-cli-core

10 package were built:
azure-cli python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner November 24, 2019 04:10
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build azure-cli python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker

@jonringer jonringer merged commit 8254f1a into NixOS:master Nov 24, 2019
@jonringer jonringer deleted the fix-portalocker branch November 24, 2019 04:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer