Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netgen-mesher: init at version 6.2.2004 #73932

Closed
wants to merge 2 commits into from
Closed

Conversation

Dema
Copy link
Contributor

@Dema Dema commented Nov 22, 2019

Motivation for this change

Wanted to try myself at creating nix packages. Closes #49532

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

meta.maintainers is NOT set.

@Dema Dema force-pushed the netgen-mesher branch 2 times, most recently from 284a3ed to 2969248 Compare November 25, 2019 20:12
@Dema Dema changed the title netgen-mesher: init at version 6.2.1909 netgen-mesher: init at version 6.2.2004 May 2, 2020
@stale
Copy link

stale bot commented Oct 30, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2020
Comment on lines 2 to 7


stdenv.mkDerivation rec {
pname = "netgen-mesher";

version = "6.2.2004";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation rec {
pname = "netgen-mesher";
version = "6.2.2004";
stdenv.mkDerivation rec {
pname = "netgen-mesher";
version = "6.2.2004";

Comment on lines +17 to +18

enableParallelBuilding = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enableParallelBuilding = true;

cmake implies that.

Comment on lines +31 to +36
meta = {
description = "An automatic 3d tetrahedral mesh generator";
homepage = "https://sourceforge.net/projects/netgen-mesher/";
license = stdenv.lib.licenses.lgpl21;
platforms = stdenv.lib.platforms.linux;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
description = "An automatic 3d tetrahedral mesh generator";
homepage = "https://sourceforge.net/projects/netgen-mesher/";
license = stdenv.lib.licenses.lgpl21;
platforms = stdenv.lib.platforms.linux;
};
meta = with lib; {
description = "An automatic 3d tetrahedral mesh generator";
homepage = "https://sourceforge.net/projects/netgen-mesher/";
license = licenses.lgpl21;
platforms = platforms.linux;
Please add yourself as a maintainer.
};

lgpl21Plus or lgpl21Only?


nativeBuildInputs = [ cmake ];

buildInputs = [ python3 tcl tk libjpeg ffmpeg zlib mesa libGLU xorg.libXmu opencascade ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is python only a build time depedency?

@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 26, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 73932 run on x86_64-linux 1

1 package built:
  • netgen-mesher

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@stale
Copy link

stale bot commented Aug 10, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@onny onny marked this pull request as draft September 7, 2022 06:32
@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add netgen package
4 participants