Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meteor: 1.8.1 -> 1.8.2 #73936

Merged
merged 1 commit into from Dec 7, 2019
Merged

meteor: 1.8.1 -> 1.8.2 #73936

merged 1 commit into from Dec 7, 2019

Conversation

kylesferrazza
Copy link
Member

Motivation for this change

New release of meteor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from cstrahan November 22, 2019 20:42
tomfitzhenry
tomfitzhenry approved these changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kylesferrazza
Copy link
Member Author

kylesferrazza commented Dec 4, 2019 •
edited

@tomfitzhenry can you merge? or are we waiting for someone who can?

@tomfitzhenry
Copy link
Contributor

kylesferrazza@ I cannot merge. But those that can merge priortise PRs that have already been reviewed.

Lassulus
Lassulus approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 262e79e into NixOS:master Dec 7, 2019
@kylesferrazza kylesferrazza deleted the update-meteor branch December 7, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfitzhenry tomfitzhenry tomfitzhenry approved these changes

@Lassulus Lassulus Lassulus approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylesferrazza @tomfitzhenry @Lassulus