Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: remove patch merged in 5.12.6 #74025

Merged
merged 1 commit into from Nov 24, 2019
Merged

qt5: remove patch merged in 5.12.6 #74025

merged 1 commit into from Nov 24, 2019
+0 −9

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2019

Patch for CVE-2019-13720 is included since QT 5.12.6, so it is unnecessary now.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill @FRidh

Sorry, something went wrong.

qt5: remove patch merged in 5.12.6
0cb0986 
Patch for CVE-2019-13720 is included since QT 5.12.6, so it is unnecessary now.
@ghost ghost requested a review from ttuegel as a code owner November 24, 2019 10:20
@FRidh FRidh changed the base branch from staging to staging-next November 24, 2019 10:29
@FRidh FRidh merged commit 2a2d3de into NixOS:staging-next Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh