nixosTests.nix-ssh-serve: port to python #73994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
force-pushed
the
nixos-test-port-nix-ssh-serve
branch
from
a608956
to
ba77344
Compare
flokli
changed the title
Comment on lines
+23
to
+30
| client.succeed("mkdir -m 700 /root/.ssh") | ||
| client.succeed( | ||
| "cat ${ssh-config} > /root/.ssh/config" | ||
| ) | ||
| client.succeed( | ||
| "cat ${snakeOilPrivateKey} > /root/.ssh/id_ecdsa" | ||
| ) | ||
| client.succeed("chmod 600 /root/.ssh/id_ecdsa") |
There was a problem hiding this comment.
Is there no way to do simple file operations on the node in the test driver with just python?
There was a problem hiding this comment.
There'll be #22401 soon to copy things generated in the VM to $out, but I don't think we can solve this one here much better currently.
We could indirect via a file in the nix store, and cp the store path, because it's also in the VM.
There was a problem hiding this comment.
There'll be #22401 soon to copy things generated in the VM to $out, but I don't think we can solve this one here much better currently.
We could indirect via a file in the nix store, and cp the store path, because it's also in the VM.
|
@GrahamcOfBorg test nix-ssh-serve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @