Adds flex gap tests #20414
Merged
Adds flex gap tests #20414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
cbiesinger,
fantasai,
kojiishi,
mrego,
plinss,
rachelandrew and
tabatkins
bfgeek
reviewed
Jan 8, 2020
tabatkins
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mostly happy path tests for
gapand it's use cases with flex. Writing modes, directions, and more are included. It's not all encompassing yet, but I do think sets a strong foundation.I'm submitting it now to get feedback, understand where I need to correct things, and also get a good idea at what's missing. It's my first PR to WPT, so feel free to share any and all information with me to ramp me up. Thanks!