Don't enqueue a scroll event for clamping or anchoring scrolls if not changed. #20413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928243
branch
2 times, most recently
from
6b2f215
to
ee165c4
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928243
branch
2 times, most recently
from
ffe9b22
to
ccf7405
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928243
branch
from
ccf7405
to
a8ba8a9
Compare
… changed. Other scroll types will still directly enqueue a scroll event. Forced layouts may cause scroll offset changes that are undone by later updates. There is no spec that requires the current behavior as far as I can tell. The CSSOM spec calls out that it should fire "when the viewport or element is scrolled" [1] [1] https://drafts.csswg.org/cssom-view/#eventdef-document-scroll Bug: 988991 Change-Id: I4e4ebcf2c5bcba8111d73ebd0b2b8a037034caaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928243 Reviewed-by: Nick Burris <nburris@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721247}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1928243
branch
from
a8ba8a9
to
9ce4cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other scroll types will still directly enqueue a scroll event.
Forced layouts may cause scroll offset changes that are undone
by later updates.
There is no spec that requires the current behavior as far as I can
tell. The CSSOM spec calls out that it should fire "when the viewport
or element is scrolled" [1]
[1] https://drafts.csswg.org/cssom-view/#eventdef-document-scroll
Bug: 988991
Change-Id: I4e4ebcf2c5bcba8111d73ebd0b2b8a037034caaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928243
Reviewed-by: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721247}