Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix steam build under allowAliases = false #73950

Merged
merged 2 commits into from Nov 23, 2019
Merged

Fix steam build under allowAliases = false #73950

merged 2 commits into from Nov 23, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Nov 23, 2019 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I'm getting the feeling we should deprecate these aliases soon. Thanks @edef1c.

@worldofpeace worldofpeace merged commit 1fc4e03 into NixOS:master Nov 23, 2019
@edef1c edef1c deleted the steam-noalias branch November 23, 2019 19:22
@edef1c
Copy link
Member Author

edef1c commented Nov 23, 2019

My general feeling is that we should only have them enabled outside CI, or maybe have a separate CI run confirming that they don't cause trouble. We should only be using aliases to provide guarantees to outside consumers. Use within nixpkgs should be fixed in the same PR as a name change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: lua 6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edef1c @worldofpeace