Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-series: use nixpkgs libssh2 #73948

Merged
merged 2 commits into from Nov 23, 2019
Merged

git-series: use nixpkgs libssh2 #73948

merged 2 commits into from Nov 23, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Nov 23, 2019 •
edited

Motivation for this change

This replaces the vendored copy from libssh2-sys.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@edef1c edef1c changed the title ###### Motivation for this change git-series: use nixpkgs libssh2 Nov 23, 2019
@ofborg ofborg bot requested a review from vmandela November 23, 2019 03:56
@edef1c edef1c merged commit 3dd8e8e into NixOS:master Nov 23, 2019
@edef1c edef1c deleted the git-series-libssh2 branch November 23, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmandela vmandela Awaiting requested review from vmandela

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@edef1c