Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jack2: 1.9.13 -> 1.9.14 #73952

Closed
wants to merge 1 commit into from
Closed

jack2: 1.9.13 -> 1.9.14 #73952

wants to merge 1 commit into from

Conversation

samueldr
Copy link
Member

This update fixes "ARM" compilation.

Changelog.

Motivation for this change

Make aarch64 stuff build. Anything depending on jack2 just fails horribly to compile.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • ✔️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • 🔲 Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • 🔲 Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Ensured that relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.
Notify maintainers

@samueldr
jack2: 1.9.13 -> 1.9.14
5b7be2a 
This update fixes "ARM" compilation
@samueldr
Copy link
Member Author

The rebuild count is 576 for x86_64. I believe it should be fine to go directly to master, it's not that much to build. Either that or staging-next if it can't go to master.

This fixes a big annoyance with aarch64, where a bunch of stuff transitively won't build. This should weigh in heavily in the branch to target.

@worldofpeace
Copy link
Contributor

@samueldr I believe I've already PR'd and merged this to staging a20dd95.
Feel free to promote the change.

@samueldr
Copy link
Member Author

samueldr commented Nov 23, 2019 •
edited

Oh, thanks, then!

What a search engine GitHub has, searching for "jack" spits no result with jack2 :/.

EDIT: WELL, now this result is in it because of the word jack in this comment.

@samueldr samueldr deleted the updates/jack2/1.9.14 branch November 23, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @worldofpeace