Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sunpy: 1.0.2 -> 1.0.6 #74019

Merged
merged 1 commit into from Nov 28, 2019
Merged

pythonPackages.sunpy: 1.0.2 -> 1.0.6 #74019

merged 1 commit into from Nov 28, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 24, 2019 •
edited

Motivation for this change

breaking apart #70684

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74019
1 package were built:
python37Packages.sunpy

@ofborg ofborg bot requested a review from costrouc November 24, 2019 06:24
@FRidh
Copy link
Member

FRidh commented Nov 24, 2019

@GrahamcOfBorg build python3Packages.sunpy

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.sunpy

asdf builds locally...

@risicle
Copy link
Contributor

risicle commented Nov 24, 2019

I suspect the darwin failure might just be platform differences - errors being reported differently. See https://bugs.python.org/issue35216

Probably best to disable that test on non-linux.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.sunpy

@jonringer
Copy link
Contributor Author

the darwin failure is with an upstream dependency, so it's not a regression

@jonringer jonringer merged commit d8a57e3 into NixOS:master Nov 28, 2019
@jonringer jonringer deleted the bump-sunpy branch November 28, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @FRidh @risicle