Fix CMake Xcode generator. #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by setting `CMAKE_RUNTIME_OUTPUT_DIRECTORY` to `$<1:${CMAKE_BINARY_DIR}/bin>`
|
|
|
Thank you for the PR. The SolveSpace project has a CLA. It looks like our CLA tracking tool requires your commit email to be added to the GitHub account—can you take a look at that? Regarding libraries ending up in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting
CMAKE_RUNTIME_OUTPUT_DIRECTORYto$<1:${CMAKE_BINARY_DIR}/bin>Without this, the resources did not end up into the SolveSpace.app file, causing a crash on startup (where it was unable to load the locales.txt file)
The reason is that the XCode project puts things into the "bin/Debug/SolveSpace.app" or "bin/Release/SolveSpace.app" folders (depending on the target), and some files ended up in "bin/SolveSpace.app" instead, this seems to fix the locales ending up in the wrong place, but I still see some files (libraries) ending up in "bin/Debug" or "bin/Release" folders.
Here is a list of them: