Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: ec3056773e2b
Choose a base ref
...
head repository: solvespace/solvespace
compare: 65d0bdffdbd4
Choose a head ref
  • 1 commit
  • 7 files changed
  • 1 contributor

Commits on Nov 23, 2019

  1. Split Canvas::FinishFrame out of Canvas::FlushFrame. 

    When drawing the graphics window, we flush it twice: once to draw
the geometry, and another time to draw the UI overlay (toolbar,
selection marquee, and FPS counter). Calling glFinish() each time
is (on most platforms) just pointlessly slow, but on macOS Catalina,
without offscreen rendering, it causes the toolbar to flicker.

Instead of calling glFinish() twice per frame in that case, call
glFlush() twice and then glFinish() once we really are done.
    @whitequark
    whitequark committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    65d0bdf View commit details
    Browse the repository at this point in the history