New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idris2: init at 0.0.0 (bf5b229) #76971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and installs fine locally.
It might be a good idea to add this to idrisPackages set.
Related: #71125
sha256 = "1ixmdy4zbllmpwmvmmqv1rj9a2y243pggf42pdqkvrkjw50zqlyj"; | ||
}; | ||
|
||
version = "0.0.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nixpkgs typically uses the YYYY-MM-DD schema for untagged sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, updated to date-based version format.
, idris, chez, racket, chickenPkgs | ||
}: | ||
|
||
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason you did not use the build-idris-package
function here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure how to make this work with build-idris-package. E.g. idris2 tests are in their own ipkg called from the makefile; buildInputs might be set incorrectly (idris should only be a nativeBuildInput for idris2 I think?); etc.
Hi is this still active? Idris 2 has just released a v0.1.0. https://www.idris-lang.org/idris-2-version-010-released.html I can pick this up. |
Sorry for the delay @locallycompact. I updated the PR to track the latest Idris2 git rev. I think this PR was never merged because it doesn't integrate with the existing idris-packages infrastructure. I'm not too familiar with how idris-packages works so this PR kind of stalled out. If you can get this accepted to nixpkgs in one way or another that'd be great! |
@lodi Hi, thanks for updating this. I guess then, anybody watching, what are the criteria for integrating it with idris-packages? How does say python2 and python3 handle this? |
Is there anything in this PR that we don't have in #88645 ? |
Nothing major no; just some minor difference to support Chicken Scheme and run tests at build time. I'll close this PR and contribute to #88645 instead. |
Motivation for this change
Added Idris2 compiler.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)