Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdkafka: 1.2.0 -> 1.2.2 #72562

Merged
merged 2 commits into from Nov 13, 2019
Merged

rdkafka: 1.2.0 -> 1.2.2 #72562

merged 2 commits into from Nov 13, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Nov 2, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rdkafka/versions.

meta.description for rdkafka is: '"librdkafka - Apache Kafka C/C++ client library"'.

meta.homepage for rdkafka is: '"https://github.com/edenhill/librdkafka"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

58 total rebuild path(s)

16 package rebuild(s)

15 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
12 x86_64-darwin rebuild(s)
16 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
clickhouse
collectd
collectd-data
haskellPackages.haskakafka
haskellPackages.hw-kafka-client
haskellPackages.hw-kafka-conduit
haskellPackages.pipes-kafka
kafkacat
osquery
python27Packages.confluent-kafka
python37Packages.confluent-kafka
python37Packages.streamz
python38Packages.confluent-kafka
python38Packages.streamz
rdkafka
rsyslog

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/hlszj6fd3wf1b2dkyhmxk3jk1kyp2zf6-rdkafka-1.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A rdkafka https://github.com/r-ryantm/nixpkgs/archive/b6e04bfc13436f4f4c888cedd32c92226ad313e4.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/hlszj6fd3wf1b2dkyhmxk3jk1kyp2zf6-rdkafka-1.2.1
ls -la /nix/store/hlszj6fd3wf1b2dkyhmxk3jk1kyp2zf6-rdkafka-1.2.1/bin

cc @Boothead for testing.

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream changelog:

Warning: v1.2.1 has a producer performance regression which may affect high-throughput producer applications. We recommend such users to stay on v1.2.0.

v1.2.1 is a maintenance release:

  • Properly handle new Kafka-framed SASL GSSAPI frame semantics on Windows (midori: fix build #2542).
    This bug was introduced in v1.2.0 and broke GSSAPI authentication on Windows.
  • Fix msgq (re)insertion code to avoid O(N^2) insert sort operations on retry (perl-file-mimeinfo: update to 0.23 and fix build on darwin #2508)
    The msgq insert code now properly handles interleaved and overlapping
    message range inserts, which may occur during Producer retries for
    high-throughput applications.
  • configure: added --disable-c11threads to avoid using libc-provided C11 threads.
  • configure: added more autoconf compatibility options to ignore

We should probably wait for the next patch release.

@c0bw3b c0bw3b changed the title rdkafka: 1.2.0 -> 1.2.1 rdkafka: 1.2.0 -> 1.2.2 Nov 13, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2019

v1.2.2 changelog:

v1.2.2 fixes the producer performance regression introduced in v1.2.1 which may affect high-throughput producer applications.

Fixes

  • Fix producer insert msgq regression in v1.2.1
  • Upgrade builtin lz4 to 1.9.2 (CVE-2019-17543)
  • Don't trigger error when broker hostname changes
  • Less strict message.max.bytes check for individual messages
  • Don't call timespec_get() on OSX (since it was removed in recent XCode)
  • configure: add --runstatedir for compatibility with autoconf
  • LZ4 is available from ProduceRequest 0, not 3
  • Address 12 code issues identified by Coverity static code analysis

Enhancements

  • Add warnings for inconsistent security configuration.
  • Optimizations to hdr histogram (stats) rollover.
  • Reorganized examples and added a cleaner consumer example, added minimal C++ producer example.
  • Print compression type per message-set when debug=msg

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 72562 1

7 package were build:
  • collectd
  • kafkacat
  • python27Packages.confluent-kafka
  • python37Packages.confluent-kafka
  • python38Packages.confluent-kafka
  • rdkafka
  • rsyslog

@c0bw3b c0bw3b merged commit 6956192 into NixOS:master Nov 13, 2019
@r-ryantm r-ryantm deleted the auto-update/rdkafka branch November 16, 2019 14:36
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 26, 2020
* rdkafka: 1.2.0 -> 1.2.1
* rdkafka: 1.2.1 -> 1.2.2
(NixOS#72562)

(cherry picked from commit 6956192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants