Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chezmoi: 1.5.5 -> 1.7.2 #72435

Merged
merged 1 commit into from Nov 2, 2019
Merged

chezmoi: 1.5.5 -> 1.7.2 #72435

merged 1 commit into from Nov 2, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jhillyerd

@ofborg ofborg bot requested review from jhillyerd and kalbasit November 1, 2019 16:04
@jhillyerd
Copy link
Contributor

jhillyerd commented Nov 2, 2019 via email

@marsam
Copy link
Contributor Author

marsam commented Nov 2, 2019

Future builds would fail when those repos are deleted

nixpkgs uses golang 1.13 which uses by default proxy.golang.org as module mirror to solve that scenario:

A module mirror is a special kind of module proxy that caches metadata and source code in its own storage system, allowing the mirror to continue to serve source code that is no longer available from the original locations. This can speed up downloads and protect you from disappearing dependencies.
https://blog.golang.org/module-mirror-launch

@marsam marsam merged commit 4386a87 into NixOS:master Nov 2, 2019
@marsam marsam deleted the update-chezmoi branch November 2, 2019 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillyerd jhillyerd jhillyerd approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jhillyerd