Spotify 1.0.96.181 -> 1.1.10.546 #72596

kolaente · 2019-11-02T16:14:51Z

at-spi2-core is required for the new dependency on libatspi.so.0.

Motivation for this change

Spotify minor version update

Things done

Notify maintainers

cc @edolstra @ftrvxmtrx @sheenobu @laMudri @timokau

Ma27

Not sure if we actually want to do the upgrade. When starting spotify from the CLI (by running ./result/bin/spotify) it segfaults right after playing the first song:

./result/bin/spotify: /nix/store/dbaf5pq3lrdmwzmkdr4k60ikglvl01rv-curl-7.66.0/lib/libcurl-gnutls.so.4: no version information available (required by ./result/bin/spotify)
/nix/store/sg41pfc2xxbgnq8m9jnd07jff5wc56kw-spotify-1.1.10.546.ge08ef575-19/share/spotify/.spotify-wrapped: /nix/store/dbaf5pq3lrdmwzmkdr4k60ikglvl01rv-curl-7.66.0/lib/libcurl-gnutls.so.4: no version information available (required by /nix/store/sg41pfc2xxbgnq8m9jnd07jff5wc56kw-spotify-1.1.10.546.ge08ef575-19/share/spotify/.spotify-wrapped)
/proc/self/exe: /nix/store/dbaf5pq3lrdmwzmkdr4k60ikglvl01rv-curl-7.66.0/lib/libcurl-gnutls.so.4: no version information available (required by /proc/self/exe)
[1102/213839.640465:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
[1]    26004 segmentation fault (core dumped)  ./result/bin/spotify

kolaente · 2019-11-02T22:17:05Z

Interesting, I hadn't noticed that.

Looks like the issue is somewhat known: https://community.spotify.com/t5/Desktop-Linux/GL-Error-on-Ubuntu-18-04/td-p/4642580
Interesting though, when Using the fix in the forum, I don't get the error message anymore, but Spotify still crashes with a segfault.

kolaente · 2019-11-02T22:21:16Z

It appears to be a problem with libcurl/gnutls: https://community.spotify.com/t5/Desktop-Linux/Ubuntu-19-04-deb-package-segfault/m-p/4764926/highlight/true#M18393

kolaente · 2019-11-03T11:54:18Z

When I run ldd on the binary and grep for libcurl, we can see it is not found:

$ ldd /nix/store/ibj5xs7q5b6215bfydbvp4fbdayhszfj-spotify-1.1.10.546.ge08ef575-19/share/spotify/.spotify-wrapped | grep libcurl
	libcurl-gnutls.so.4 => not found

Oddly enough, running nix-locate libcurl-gnutls.so.4 --top-level does not return any results.

(On another note, libcurl-gnutls was already present in the previous version, so I'm not sure if that's really causing the segfault here)

kolaente · 2019-11-03T12:03:48Z

Running patchelf --print-needed on the new and old binary suggests there is only libresolv.so.2 which is new, but that is included in libc afaik:

$ diff -y patchelf-old patchelf-new
libasound.so.2							libasound.so.2
libresolv.so.2						      <
libcurl-gnutls.so.4						libcurl-gnutls.so.4
libdl.so.2							libdl.so.2
libatomic.so.1							libatomic.so.1
libm.so.6							libm.so.6
libX11.so.6							libX11.so.6
libcef.so							libcef.so
libz.so.1							libz.so.1
libpthread.so.0							libpthread.so.0
librt.so.1							librt.so.1
libglib-2.0.so.0						libglib-2.0.so.0
libgtk-x11-2.0.so.0						libgtk-x11-2.0.so.0
libgdk-x11-2.0.so.0						libgdk-x11-2.0.so.0
libatk-1.0.so.0							libatk-1.0.so.0
libgio-2.0.so.0							libgio-2.0.so.0
libpangoft2-1.0.so.0						libpangoft2-1.0.so.0
libpangocairo-1.0.so.0						libpangocairo-1.0.so.0
libgdk_pixbuf-2.0.so.0						libgdk_pixbuf-2.0.so.0
libcairo.so.2							libcairo.so.2
libpango-1.0.so.0						libpango-1.0.so.0
libfontconfig.so.1						libfontconfig.so.1
libgobject-2.0.so.0						libgobject-2.0.so.0
libfreetype.so.6						libfreetype.so.6
libgcc_s.so.1							libgcc_s.so.1
libc.so.6							libc.so.6

Diffing the ldd output of the old and new binary indicates there is only libatspi.so.0 which is new while libresolv.so.2 is not needed anymore:

$ diff -y ldd-old ldd-new          
	/nix/store/pnd2kl27sag76h23wa5kl95a76n3k9i3-glibc-2.2 |		/nix/store/qn76sklvyalzw9ilnxz6sh0020gl2qn6-glibc-2.2
	libX11-xcb.so.1 => not found					libX11-xcb.so.1 => not found
	libX11.so.6 => not found					libX11.so.6 => not found
	libX11.so.6 => not found					libX11.so.6 => not found
	libXcomposite.so.1 => not found					libXcomposite.so.1 => not found
	libXcursor.so.1 => not found					libXcursor.so.1 => not found
	libXdamage.so.1 => not found					libXdamage.so.1 => not found
	libXext.so.6 => not found					libXext.so.6 => not found
	libXfixes.so.3 => not found					libXfixes.so.3 => not found
	libXi.so.6 => not found						libXi.so.6 => not found
	libXrandr.so.2 => not found					libXrandr.so.2 => not found
	libXrender.so.1 => not found					libXrender.so.1 => not found
	libXss.so.1 => not found					libXss.so.1 => not found
	libXtst.so.6 => not found					libXtst.so.6 => not found
	libasound.so.2 => not found					libasound.so.2 => not found
	libasound.so.2 => not found					libasound.so.2 => not found
	libatk-1.0.so.0 => not found					libatk-1.0.so.0 => not found
	libatk-1.0.so.0 => not found					libatk-1.0.so.0 => not found
	libatk-bridge-2.0.so.0 => not found				libatk-bridge-2.0.so.0 => not found
	libatomic.so.1 => not found					libatomic.so.1 => not found
	libc.so.6 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3k |		libatspi.so.0 => not found
							      >		libc.so.6 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3k
	libcairo.so.2 => not found					libcairo.so.2 => not found
	libcef.so => /nix/store/6a7r0pfr2srqf7hjj5akw636rdxaq |		libcef.so => /nix/store/8pr23qkga31sf0ma40107a7dnzpk0
	libcurl-gnutls.so.4 => not found				libcurl-gnutls.so.4 => not found
	libdbus-1.so.3 => not found					libdbus-1.so.3 => not found
	libdl.so.2 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3 |		libdl.so.2 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3
	libexpat.so.1 => not found					libexpat.so.1 => not found
	libfontconfig.so.1 => not found					libfontconfig.so.1 => not found
	libfontconfig.so.1 => not found					libfontconfig.so.1 => not found
	libfreetype.so.6 => not found					libfreetype.so.6 => not found
	libgcc_s.so.1 => /nix/store/pnd2kl27sag76h23wa5kl95a7 |		libgcc_s.so.1 => /nix/store/pnd2kl27sag76h23wa5kl95a7
	libgdk-x11-2.0.so.0 => not found				libgdk-x11-2.0.so.0 => not found
	libgdk_pixbuf-2.0.so.0 => not found				libgdk_pixbuf-2.0.so.0 => not found
	libgio-2.0.so.0 => not found					libgio-2.0.so.0 => not found
	libgio-2.0.so.0 => not found					libgio-2.0.so.0 => not found
	libglib-2.0.so.0 => not found					libglib-2.0.so.0 => not found
	libglib-2.0.so.0 => not found					libglib-2.0.so.0 => not found
	libgobject-2.0.so.0 => not found				libgobject-2.0.so.0 => not found
	libgobject-2.0.so.0 => not found				libgobject-2.0.so.0 => not found
	libgtk-x11-2.0.so.0 => not found				libgtk-x11-2.0.so.0 => not found
	libm.so.6 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3k |		libm.so.6 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3k
	libnspr4.so => not found					libnspr4.so => not found
	libnss3.so => not found						libnss3.so => not found
	libnssutil3.so => not found					libnssutil3.so => not found
	libpango-1.0.so.0 => not found					libpango-1.0.so.0 => not found
	libpango-1.0.so.0 => not found					libpango-1.0.so.0 => not found
	libpangocairo-1.0.so.0 => not found				libpangocairo-1.0.so.0 => not found
	libpangocairo-1.0.so.0 => not found				libpangocairo-1.0.so.0 => not found
	libpangoft2-1.0.so.0 => not found				libpangoft2-1.0.so.0 => not found
	libpthread.so.0 => /nix/store/pnd2kl27sag76h23wa5kl95 |		libpthread.so.0 => /nix/store/pnd2kl27sag76h23wa5kl95
	libresolv.so.2 => /nix/store/pnd2kl27sag76h23wa5kl95a |		librt.so.1 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3
	librt.so.1 => /nix/store/pnd2kl27sag76h23wa5kl95a76n3 <
	libsmime3.so => not found					libsmime3.so => not found
	libxcb.so.1 => not found					libxcb.so.1 => not found
	libz.so.1 => not found						libz.so.1 => not found
	linux-vdso.so.1 (0x00007fffba933000)		      |		linux-vdso.so.1 (0x00007fffda333000)

libatspi.so.0 seems to come from at-spi2-core.out:

$ nix-locate libatspi.so.0 --top-level
at-spi2-core.out                                      0 s /nix/store/pzmfn425raph0flmaxidf0nbsma4pib4-at-spi2-core-2.32.1/lib/libatspi.so.0

Since that was a new dependency, maybe that's where the problem is coming from?

(As you can probably tell by now, I'm still a noob with all this, any hints are appreciated)

timokau · 2019-11-03T15:15:01Z

Prior work: #57800, #65602

Would be great if you could get this to work.

kolaente · 2019-11-04T13:50:33Z

This is the ldd ouput from an ubuntu machine running spotify 1.1.10.546.ge08ef575 (I think the deb package, not the snap`:

$ ldd `which spotify`
	linux-vdso.so.1 (0x00007fff29bd3000)
	libasound.so.2 => /usr/lib/x86_64-linux-gnu/libasound.so.2 (0x00007f30f257e000)
	libcurl-gnutls.so.4 => /usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4 (0x00007f30f2301000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f30f20fd000)
	libatomic.so.1 => /usr/lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f30f1ef5000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f30f1b57000)
	libX11.so.6 => /usr/lib/x86_64-linux-gnu/libX11.so.6 (0x00007f30f181f000)
	libcef.so => not found
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f30f1602000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f30f13e3000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f30f11db000)
	libglib-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007f30f0ec4000)
	libgtk-x11-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0 (0x00007f30f0882000)
	libgdk-x11-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgdk-x11-2.0.so.0 (0x00007f30f05cd000)
	libatk-1.0.so.0 => /usr/lib/x86_64-linux-gnu/libatk-1.0.so.0 (0x00007f30f03a7000)
	libgio-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0 (0x00007f30f0008000)
	libpangoft2-1.0.so.0 => /usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0 (0x00007f30efdf2000)
	libpangocairo-1.0.so.0 => /usr/lib/x86_64-linux-gnu/libpangocairo-1.0.so.0 (0x00007f30efbe5000)
	libgdk_pixbuf-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0 (0x00007f30ef9c1000)
	libcairo.so.2 => /usr/lib/x86_64-linux-gnu/libcairo.so.2 (0x00007f30ef6a4000)
	libpango-1.0.so.0 => /usr/lib/x86_64-linux-gnu/libpango-1.0.so.0 (0x00007f30ef457000)
	libfontconfig.so.1 => /usr/lib/x86_64-linux-gnu/libfontconfig.so.1 (0x00007f30ef212000)
	libgobject-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 (0x00007f30eefbe000)
	libfreetype.so.6 => /usr/lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007f30eed0a000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f30eeaf2000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f30ee701000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f30f2885000)
	libnghttp2.so.14 => /usr/lib/x86_64-linux-gnu/libnghttp2.so.14 (0x00007f30ee4dc000)
	libidn2.so.0 => /usr/lib/x86_64-linux-gnu/libidn2.so.0 (0x00007f30ee2bf000)
	librtmp.so.1 => /usr/lib/x86_64-linux-gnu/librtmp.so.1 (0x00007f30ee0a3000)
	libpsl.so.5 => /usr/lib/x86_64-linux-gnu/libpsl.so.5 (0x00007f30ede95000)
	libnettle.so.6 => /usr/lib/x86_64-linux-gnu/libnettle.so.6 (0x00007f30edc5f000)
	libgnutls.so.30 => /usr/lib/x86_64-linux-gnu/libgnutls.so.30 (0x00007f30ed8fa000)
	libgssapi_krb5.so.2 => /usr/lib/x86_64-linux-gnu/libgssapi_krb5.so.2 (0x00007f30ed6af000)
	libldap_r-2.4.so.2 => /usr/lib/x86_64-linux-gnu/libldap_r-2.4.so.2 (0x00007f30ed45d000)
	liblber-2.4.so.2 => /usr/lib/x86_64-linux-gnu/liblber-2.4.so.2 (0x00007f30ed24f000)
	libxcb.so.1 => /usr/lib/x86_64-linux-gnu/libxcb.so.1 (0x00007f30ed027000)
	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f30ecdb5000)
	libgmodule-2.0.so.0 => /usr/lib/x86_64-linux-gnu/libgmodule-2.0.so.0 (0x00007f30ecbb1000)
	libXfixes.so.3 => /usr/lib/x86_64-linux-gnu/libXfixes.so.3 (0x00007f30ec9ab000)
	libXrender.so.1 => /usr/lib/x86_64-linux-gnu/libXrender.so.1 (0x00007f30ec7a1000)
	libXinerama.so.1 => /usr/lib/x86_64-linux-gnu/libXinerama.so.1 (0x00007f30ec59e000)
	libXi.so.6 => /usr/lib/x86_64-linux-gnu/libXi.so.6 (0x00007f30ec38e000)
	libXrandr.so.2 => /usr/lib/x86_64-linux-gnu/libXrandr.so.2 (0x00007f30ec183000)
	libXcursor.so.1 => /usr/lib/x86_64-linux-gnu/libXcursor.so.1 (0x00007f30ebf79000)
	libXcomposite.so.1 => /usr/lib/x86_64-linux-gnu/libXcomposite.so.1 (0x00007f30ebd76000)
	libXdamage.so.1 => /usr/lib/x86_64-linux-gnu/libXdamage.so.1 (0x00007f30ebb73000)
	libXext.so.6 => /usr/lib/x86_64-linux-gnu/libXext.so.6 (0x00007f30eb961000)
	libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007f30eb739000)
	libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007f30eb51e000)
	libmount.so.1 => /lib/x86_64-linux-gnu/libmount.so.1 (0x00007f30eb2ca000)
	libharfbuzz.so.0 => /usr/lib/x86_64-linux-gnu/libharfbuzz.so.0 (0x00007f30eb02c000)
	libpixman-1.so.0 => /usr/lib/x86_64-linux-gnu/libpixman-1.so.0 (0x00007f30ead87000)
	libpng16.so.16 => /usr/lib/x86_64-linux-gnu/libpng16.so.16 (0x00007f30eab55000)
	libxcb-shm.so.0 => /usr/lib/x86_64-linux-gnu/libxcb-shm.so.0 (0x00007f30ea952000)
	libxcb-render.so.0 => /usr/lib/x86_64-linux-gnu/libxcb-render.so.0 (0x00007f30ea745000)
	libthai.so.0 => /usr/lib/x86_64-linux-gnu/libthai.so.0 (0x00007f30ea53c000)
	libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007f30ea30a000)
	libffi.so.6 => /usr/lib/x86_64-linux-gnu/libffi.so.6 (0x00007f30ea102000)
	libunistring.so.2 => /usr/lib/x86_64-linux-gnu/libunistring.so.2 (0x00007f30e9d84000)
	libhogweed.so.4 => /usr/lib/x86_64-linux-gnu/libhogweed.so.4 (0x00007f30e9b50000)
	libgmp.so.10 => /usr/lib/x86_64-linux-gnu/libgmp.so.10 (0x00007f30e98cf000)
	libp11-kit.so.0 => /usr/lib/x86_64-linux-gnu/libp11-kit.so.0 (0x00007f30e95a0000)
	libtasn1.so.6 => /usr/lib/x86_64-linux-gnu/libtasn1.so.6 (0x00007f30e938d000)
	libkrb5.so.3 => /usr/lib/x86_64-linux-gnu/libkrb5.so.3 (0x00007f30e90b7000)
	libk5crypto.so.3 => /usr/lib/x86_64-linux-gnu/libk5crypto.so.3 (0x00007f30e8e85000)
	libcom_err.so.2 => /lib/x86_64-linux-gnu/libcom_err.so.2 (0x00007f30e8c81000)
	libkrb5support.so.0 => /usr/lib/x86_64-linux-gnu/libkrb5support.so.0 (0x00007f30e8a76000)
	libsasl2.so.2 => /usr/lib/x86_64-linux-gnu/libsasl2.so.2 (0x00007f30e885b000)
	libgssapi.so.3 => /usr/lib/x86_64-linux-gnu/libgssapi.so.3 (0x00007f30e861a000)
	libXau.so.6 => /usr/lib/x86_64-linux-gnu/libXau.so.6 (0x00007f30e8416000)
	libXdmcp.so.6 => /usr/lib/x86_64-linux-gnu/libXdmcp.so.6 (0x00007f30e8210000)
	libblkid.so.1 => /lib/x86_64-linux-gnu/libblkid.so.1 (0x00007f30e7fc3000)
	libgraphite2.so.3 => /usr/lib/x86_64-linux-gnu/libgraphite2.so.3 (0x00007f30e7d96000)
	libdatrie.so.1 => /usr/lib/x86_64-linux-gnu/libdatrie.so.1 (0x00007f30e7b8f000)
	libkeyutils.so.1 => /lib/x86_64-linux-gnu/libkeyutils.so.1 (0x00007f30e798b000)
	libheimntlm.so.0 => /usr/lib/x86_64-linux-gnu/libheimntlm.so.0 (0x00007f30e7782000)
	libkrb5.so.26 => /usr/lib/x86_64-linux-gnu/libkrb5.so.26 (0x00007f30e74f5000)
	libasn1.so.8 => /usr/lib/x86_64-linux-gnu/libasn1.so.8 (0x00007f30e7253000)
	libhcrypto.so.4 => /usr/lib/x86_64-linux-gnu/libhcrypto.so.4 (0x00007f30e701d000)
	libroken.so.18 => /usr/lib/x86_64-linux-gnu/libroken.so.18 (0x00007f30e6e07000)
	libbsd.so.0 => /lib/x86_64-linux-gnu/libbsd.so.0 (0x00007f30e6bf2000)
	libuuid.so.1 => /lib/x86_64-linux-gnu/libuuid.so.1 (0x00007f30e69eb000)
	libwind.so.0 => /usr/lib/x86_64-linux-gnu/libwind.so.0 (0x00007f30e67c2000)
	libheimbase.so.1 => /usr/lib/x86_64-linux-gnu/libheimbase.so.1 (0x00007f30e65b3000)
	libhx509.so.5 => /usr/lib/x86_64-linux-gnu/libhx509.so.5 (0x00007f30e6369000)
	libsqlite3.so.0 => /usr/lib/x86_64-linux-gnu/libsqlite3.so.0 (0x00007f30e6060000)
	libcrypt.so.1 => /lib/x86_64-linux-gnu/libcrypt.so.1 (0x00007f30e5e28000)

As you can see, there are quite some libraries not linked in the nixos version. I'm not sure if that is an issue though... but since we're getting a segfault, it may be?

kolaente · 2019-11-05T20:53:54Z

After reading through #65602, I got it to work with pulseaudio with this: #65602 (comment), effectivly just adding libpulseaudio to the deps.

My pulseaudio config is this:

hardware.pulseaudio = {
  enable = true;
  package = pkgs.pulseaudioFull;
};

I could somewhat get it to work with alsa, but not good. I did not get any audio from other apps when running spotify with that... and it only started playing when I stopped everything else which produced audio. Using pulseaudio is a more stable experience for me.

@timokau @angristan @ajs124 Could you test if this works for you?

Ma27

Works for me. Would like to have at least another tester before merging though.

timokau

Works for me as well. Probably no use in trying to support alsa when upstream clearly doesn't care for it.

timokau · 2019-11-06T21:33:48Z

Thanks for tackling this @kolaente!

kolaente · 2019-11-07T21:08:52Z

Should I backport this to 19.09?

timokau · 2019-11-07T21:12:45Z

No, unless I'm missing some specific reason to backport. We mostly just backport fixes and maybe minor releases. Normal updates always have the potential of breaking stuff, which goes against the idea of stable channels.

kolaente · 2019-11-07T21:17:20Z

@timokau Makes sense, thanks for the explaination!

Spotify 1.0.96.181.gf6bc1b6b-12 -> 1.1.10.546.ge08ef575-19

40d5e2d

ofborg bot requested review from edolstra, laMudri and timokau November 2, 2019 16:23

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Nov 2, 2019

Ma27 reviewed Nov 2, 2019

View reviewed changes

kolaente added 2 commits November 5, 2019 20:43

Merge branch 'master' into update/spotify

c380f48

Add libpulseaudio to not have spotify crash when trying to play music

62fa5d3

kolaente mentioned this pull request Nov 5, 2019

spotify: 1.0.96.181 -> 1.1.10.546 #65602

Merged

10 tasks

Ma27 approved these changes Nov 6, 2019

View reviewed changes

timokau approved these changes Nov 6, 2019

View reviewed changes

Ma27 merged commit 5f3956f into NixOS:master Nov 6, 2019

kolaente deleted the update/spotify branch November 6, 2019 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spotify 1.0.96.181 -> 1.1.10.546 #72596

Spotify 1.0.96.181 -> 1.1.10.546 #72596

kolaente commented Nov 2, 2019

Ma27 left a comment

kolaente commented Nov 2, 2019

kolaente commented Nov 2, 2019 •

edited

kolaente commented Nov 3, 2019

kolaente commented Nov 3, 2019

timokau commented Nov 3, 2019

kolaente commented Nov 4, 2019

kolaente commented Nov 5, 2019

Ma27 left a comment

timokau left a comment

timokau commented Nov 6, 2019

kolaente commented Nov 7, 2019

timokau commented Nov 7, 2019

kolaente commented Nov 7, 2019

Spotify 1.0.96.181 -> 1.1.10.546 #72596

Spotify 1.0.96.181 -> 1.1.10.546 #72596

Conversation

kolaente commented Nov 2, 2019

Motivation for this change

Things done

Notify maintainers

Ma27 left a comment

Choose a reason for hiding this comment

kolaente commented Nov 2, 2019

kolaente commented Nov 2, 2019 • edited

kolaente commented Nov 3, 2019

kolaente commented Nov 3, 2019

timokau commented Nov 3, 2019

kolaente commented Nov 4, 2019

kolaente commented Nov 5, 2019

Ma27 left a comment

Choose a reason for hiding this comment

timokau left a comment

Choose a reason for hiding this comment

timokau commented Nov 6, 2019

kolaente commented Nov 7, 2019

timokau commented Nov 7, 2019

kolaente commented Nov 7, 2019

kolaente commented Nov 2, 2019 •

edited