Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cachy: 0.2.0 -> 0.3.0 #72445

Closed
wants to merge 2 commits into from
Closed

pythonPackages.cachy: 0.2.0 -> 0.3.0 #72445

wants to merge 2 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 1, 2019 •
edited

Motivation for this change

closes #67043

Added tests to make sure I wasn't breaking anything when removing version bound. Unfortunately, poetry is self-bootstrapping (i.e. need a previous version to install it), I had to do both a pypi fetch for the installation, and a github fetch for the tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[4 built, 7 copied (1.7 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72445
6 package were build:
poetry python27Packages.cachy python27Packages.poetry python37Packages.cachy python38Packages.cachy python38Packages.poetry

@jonringer jonringer requested a review from FRidh as a code owner November 1, 2019 16:13
@jonringer jonringer changed the title Bump cachy pythonPackages.cachy: 0.2.0 -> 0.3.0 Nov 1, 2019
@ofborg ofborg bot requested a review from jbaum98 November 1, 2019 16:54
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build poetry python27Packages.cachy python27Packages.poetry python37Packages.cachy python38Packages.cachy python38Packages.poetry

risicle
risicle reviewed Nov 2, 2019
View reviewed changes
pkgs/development/python-modules/poetry/default.nix
repo = "poetry";
rev = version;
sha256 = "004s747wkil5f00r0vjff73r6vhlrrcnfan2k7pl7gyf62wfp02a";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needs must, I guess - at least both package fetches are based on the same version so they shouldn't diverge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, which is why i moved the version to the the let scope...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only way I thought i could sneak tests in... didn't want to break it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus, there's apparently no packages that use poetry to build... so i can't use them as a way to verify correctness :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source can be used by using format = "pyproject";

Copy link
Contributor Author

@jonringer jonringer Nov 3, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the raw source of poetry can't be installed without a previous version of poetry, the github pull is just to get the tests.

@risicle
Copy link
Contributor

risicle commented Nov 2, 2019

nox-review happy for me macos 10.13 & non-nixos linux x86_64

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build poetry python27Packages.cachy python27Packages.poetry python37Packages.cachy python38Packages.cachy python38Packages.poetry

not sure why darwin's tests are still all passing, but then the drv still fails to build....

@jonringer
Copy link
Contributor Author

oh python38Packages.rednose is broken, the other's are good

@FRidh is this too hacky for you? :)

FRidh
FRidh requested changes Nov 3, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually wait I think it can be done...

@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

@jonringer how hacky is this? :-D
48749ff

@jonringer
Copy link
Contributor Author

I'll try again by modifying the python path, might be possible

@FRidh FRidh mentioned this pull request Nov 4, 2019
Closed
@jonringer
Copy link
Contributor Author

I feel like that would make it a pain to update :)

@FRidh
Copy link
Member

FRidh commented Nov 4, 2019

I don't know. As long as poetry works directly from the source directory, I don't see any problem with it. Replacing versions is essentially the same as using substituteInPlace or sed. The big advantage here is that we're building straight from VCS. Recently I did the same for setuptools, pip and wheel, because that way you can test e.g. dev versions. Now, I don't think it's likely anyone will do that for poetry, at least not as long as its a relatively unknown project.

@FRidh
Copy link
Member

FRidh commented Nov 5, 2019

Regarding poetry again. In the future pip will support self-hosting backends, so the PYTHONPATH part can be removed as soon as poetry implements it.
https://discuss.python.org/t/pep-517-backend-bootstrapping/789

@jonringer jonringer closed this Dec 19, 2019
@jonringer jonringer deleted the bump-cachy branch December 19, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@FRidh FRidh FRidh requested changes

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @risicle @FRidh