Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.night-theme-switcher: init at 2.1 #72043

Merged
merged 1 commit into from Nov 3, 2019
Merged

gnomeExtensions.night-theme-switcher: init at 2.1 #72043

merged 1 commit into from Nov 3, 2019

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Oct 26, 2019 •
edited

Motivation for this change

Add the Night Theme Switcher GNOME extension

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jtojnar @worldofpeace @hedning

worldofpeace
worldofpeace approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the extension and it works properly.

@worldofpeace worldofpeace force-pushed the gnomeExtensions.night-theme-switcher-init branch from f13b721 to 0724efc Compare November 3, 2019 14:34
@worldofpeace worldofpeace merged commit eee1e3c into NixOS:master Nov 3, 2019
@worldofpeace
Copy link
Contributor

Thanks @jonafato ✨

@jonafato jonafato deleted the gnomeExtensions.night-theme-switcher-init branch November 3, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonafato @worldofpeace